1485741 - Use full task names in filtering tasks for 'mach try coverage'

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Gabriel Vîjială [:gabriel-v]]

Due to the current schema of the chunk mapping database, suite names taken from the chunk mapping are not consistent with the task names, so we're using string inclusion (the python 'in' operator) to find the tasks that need to be run.

In order to fix this, we need to add more columns to the chunk mapping database [1] and use those columns in 'mach try coverage' [2].

[1] https://github.com/mozilla/release-services/issues/1426
[2] tools/tryselect/selectors/coverage.py, in function filter_tasks_by_chunks

Comment 1

[Marco Castelluccio [:marco]]

We can probably avoid fixing [1].

In the code coverage bot, in order to get the chunk name from the task name we do:
> TEST_PLATFORMS = [
>     'test-linux64-ccov/debug',
>     'test-windows10-64-ccov/debug',
>     'test-android-em-4.3-arm7-api-16-ccov/debug'
> ]
> 
> for t in TEST_PLATFORMS:
>     if task_name.startswith(t):
>         task_name = task_name[len(t) + 1:]
>         break
> 
> chunk_name = '-'.join([p for p in name.split('-') if p != 'e10s'])

So we just need to implement another policy to match this in filter_tasks_by_chunks.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: More precisely select chunks to run and assert when there are unexpected conditions

I've updated the rules to more precisely select the chunks to run (we were choosing a lot of things with the `in`).

I've added several assertions to make sure there are no unexpected conditions. We might be more lenient in the future but for now I want to make sure we are aware of anything that might break things.

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 9025076 [details] [diff] [review]
More precisely select chunks to run and assert when there are unexpected conditions

Review of attachment 9025076 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55ef2d374921
More precisely select chunks to run and assert when there are unexpected conditions. r=ahal

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/55ef2d374921