Closed
Bug 1485766
Opened 6 years ago
Closed 6 years ago
Drop the manually implementation of ToCSS for BasicShape::Polygon
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
Details
Attachments
(1 file)
While working on ToCSS for |clip-path:path()|, I think it's possible to use ToCSS custom derive for Polygon [1]. [1] https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/servo/components/style/values/generics/basic_shape.rs#119
|
Assignee | |
Comment 1•6 years ago
|
||
The implementation of ToCSS for Polygon has some rule, and we could use skip_if to handle and serialization of fill-rule. However, we should derive ToCSS for the pair of LengthOrPercentage, so define a new type for it.
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9003610 [details] Bug 1485766 - Drop the manually implementation of ToCSS for BasicShape::Polygon. Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #9003610 -
Flags: review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ede805f4bbecc6fd57f559d9a824c0a30f71804
Pushed by boris.chiou@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f7ad979ef6da Drop the manually implementation of ToCSS for BasicShape::Polygon. r=emilio
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f7ad979ef6da
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•