Closed Bug 1485766 Opened Last year Closed Last year

Drop the manually implementation of ToCSS for BasicShape::Polygon

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: boris, Assigned: boris)

References

Details

Attachments

(1 file)

While working on ToCSS for |clip-path:path()|, I think it's possible to use ToCSS custom derive for Polygon [1].

[1] https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/servo/components/style/values/generics/basic_shape.rs#119
The implementation of ToCSS for Polygon has some rule, and we could use skip_if
to handle and serialization of fill-rule. However, we should derive ToCSS for
the pair of LengthOrPercentage, so define a new type for it.
Comment on attachment 9003610 [details]
Bug 1485766 - Drop the manually implementation of ToCSS for BasicShape::Polygon.

Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #9003610 - Flags: review+
Pushed by boris.chiou@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f7ad979ef6da
Drop the manually implementation of ToCSS for BasicShape::Polygon. r=emilio
https://hg.mozilla.org/mozilla-central/rev/f7ad979ef6da
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.