Closed Bug 1485789 Opened Last year Closed Last year

Cleanup visitUntypedPhi() and visitTypedPhi().

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: sstangl, Assigned: sstangl)

Details

Attachments

(1 file)

46 bytes, text/x-phabricator-request
mgaudet
: review+
Details | Review
These functions are not obvious to read, but they easily could be:

https://bugzilla.mozilla.org/show_bug.cgi?id=1483030#c3
For https://bugzilla.mozilla.org/show_bug.cgi?id=1485789, from the linked discussion.

Normally Kannan should review this, since he asked for it, but I'm using this as an excuse to try out Phabricator, and it looks like he hasn't linked his Bugzilla account yet.
Comment on attachment 9003643 [details]
Cleanup defineUntypedPhi().

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.
Attachment #9003643 - Flags: review+
I have no idea how to land this.

Attempting to use Phabricator's "Lando" gives the following message:

"This diff does not have the proper author information uploaded to Phabricator. This can happen if the diff was created using the web UI, or a non standard client. The author should re-upload the diff to Phabricator using the "arc diff" command."

I wasn't able to get arcanist working the last time I tried to set it up, and don't have time to fuss about with it currently.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cfc3293b75f8
Cleanup defineUntypedPhi(). r=mgaudet
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cfc3293b75f8
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.