1485789 - Cleanup visitUntypedPhi() and visitTypedPhi().

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P5)

Description

[Sean Stangl [:sstangl]]

These functions are not obvious to read, but they easily could be:

https://bugzilla.mozilla.org/show_bug.cgi?id=1483030#c3

Comment 1

[Sean Stangl [:sstangl]]

Attachment: Cleanup defineUntypedPhi().

For https://bugzilla.mozilla.org/show_bug.cgi?id=1485789, from the linked discussion.

Normally Kannan should review this, since he asked for it, but I'm using this as an excuse to try out Phabricator, and it looks like he hasn't linked his Bugzilla account yet.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Comment on attachment 9003643 [details]
Cleanup defineUntypedPhi().

Matthew Gaudet (he/him) [:mgaudet] has approved the revision.

Comment 3

[Sean Stangl [:sstangl]]

I have no idea how to land this.

Attempting to use Phabricator's "Lando" gives the following message:

"This diff does not have the proper author information uploaded to Phabricator. This can happen if the diff was created using the web UI, or a non standard client. The author should re-upload the diff to Phabricator using the "arc diff" command."

I wasn't able to get arcanist working the last time I tried to set it up, and don't have time to fuss about with it currently.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfc3293b75f8
Cleanup defineUntypedPhi(). r=mgaudet

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/cfc3293b75f8