1485809 - Exception in LayerSession$Compositor.setDefaultClearColor()

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Colin ran into this while implementing tab switching in Focus.

java.lang.NullPointerException: NativeException NullHandle() [T = nsWindow::LayerViewSupport]
       at org.mozilla.gecko.gfx.LayerSession$Compositor.setDefaultClearColor(Native Method)
       at org.mozilla.gecko.gfx.CompositorController.onCompositorReady(CompositorController.java:35)
       at org.mozilla.gecko.gfx.LayerSession.onCompositorReady(LayerSession.java:451)
       at org.mozilla.gecko.gfx.LayerSession$1.run(LayerSession.java:392)
       at android.os.Handler.handleCallback(Handler.java:873)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:193)
       at android.app.ActivityThread.main(ActivityThread.java:6669)
       at java.lang.reflect.Method.invoke(Native Method)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

We think Jim is looking at similar cases elsewhere.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to David Bolter [:davidb] (NeedInfo me for attention) from comment #1)

We think Jim is looking at similar cases elsewhere.

This is no longer true.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is showing up in the Play Store as a top 10 crash for Focus, adjusting priority.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1485809 - Fix race with compositor attachment r?#geckoview-reviewers

We can receive GeckoSession.onCompositorDetached() before
GeckoSession.onCompositorReady() has run, so guard against this
by ensuring the compositor is attached in onCompositorReady().

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70d0497c3cb6
Fix race with compositor attachment r=geckoview-reviewers,droeh#geckoview-reviewers

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/70d0497c3cb6

Comment 7

[Chris Peterson [:cpeterson]]

65=wontfix

I see a few of these crashes from Focus + GV 65 users in the Google Play Console.