Closed Bug 1485809 Opened Last year Closed 10 months ago

Exception in LayerSession$Compositor.setDefaultClearColor()

Categories

(GeckoView :: General, defect, P1)

62 Branch
defect

Tracking

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: snorp, Assigned: snorp)

Details

(Keywords: crash, Whiteboard: [geckoview])

Attachments

(1 file)

Colin ran into this while implementing tab switching in Focus.

java.lang.NullPointerException: NativeException NullHandle() [T = nsWindow::LayerViewSupport]
       at org.mozilla.gecko.gfx.LayerSession$Compositor.setDefaultClearColor(Native Method)
       at org.mozilla.gecko.gfx.CompositorController.onCompositorReady(CompositorController.java:35)
       at org.mozilla.gecko.gfx.LayerSession.onCompositorReady(LayerSession.java:451)
       at org.mozilla.gecko.gfx.LayerSession$1.run(LayerSession.java:392)
       at android.os.Handler.handleCallback(Handler.java:873)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:193)
       at android.app.ActivityThread.main(ActivityThread.java:6669)
       at java.lang.reflect.Method.invoke(Native Method)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Keywords: crash
Priority: -- → P1
Version: Firefox 59 → Firefox 62
We think Jim is looking at similar cases elsewhere.
Priority: P1 → P3
Product: Firefox for Android → GeckoView
Version: Firefox 62 → 62 Branch

(In reply to David Bolter [:davidb] (NeedInfo me for attention) from comment #1)

We think Jim is looking at similar cases elsewhere.

This is no longer true.

This is showing up in the Play Store as a top 10 crash for Focus, adjusting priority.

Assignee: nobody → snorp
Priority: P3 → P1

We can receive GeckoSession.onCompositorDetached() before
GeckoSession.onCompositorReady() has run, so guard against this
by ensuring the compositor is attached in onCompositorReady().

Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70d0497c3cb6
Fix race with compositor attachment r=geckoview-reviewers,droeh#geckoview-reviewers
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

65=wontfix

I see a few of these crashes from Focus + GV 65 users in the Google Play Console.

You need to log in before you can comment on or make changes to this bug.