Use cbindgen for basic_shape::FillRule

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: boris, Assigned: boris)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Fill rule [1] is a pretty simple enum, and we could use cbindgen to generate it to avoid any conversion.

[1] https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/servo/components/style/values/generics/basic_shape.rs#134
Just a minor fix to use cbindgen to avoid the conversion between
basic_shape::FillRule and mozilla::StyleFillRule.
Comment on attachment 9003645 [details]
Bug 1485823 - Use cbindgen for basic_shape::FillRule.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9003645 - Flags: review+
Pushed by boris.chiou@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a333f450838
Use cbindgen for basic_shape::FillRule. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/4a333f450838
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.