Closed Bug 1485823 Opened 2 years ago Closed 2 years ago

Use cbindgen for basic_shape::FillRule

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: boris, Assigned: boris)

Details

Attachments

(1 file)

Fill rule [1] is a pretty simple enum, and we could use cbindgen to generate it to avoid any conversion.

[1] https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/servo/components/style/values/generics/basic_shape.rs#134
Just a minor fix to use cbindgen to avoid the conversion between
basic_shape::FillRule and mozilla::StyleFillRule.
Comment on attachment 9003645 [details]
Bug 1485823 - Use cbindgen for basic_shape::FillRule.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9003645 - Flags: review+
Pushed by boris.chiou@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a333f450838
Use cbindgen for basic_shape::FillRule. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/4a333f450838
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.