Closed
Bug 1485854
Opened 6 years ago
Closed 6 years ago
[mozdevice] adb.py _check_adb_root should be more resilient to differing outputs
Categories
(Testing :: Mozbase, enhancement)
Testing
Mozbase
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
2.49 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
In adb.py's ADBDevice._check_adb_root attempts to determine if adbd can be restarted as root by looking at the output of the adb root command. However, it turns out that some devices fail to restart adbd as root but do not emit any output. We can improve this to eliminate the possibility of differing outputs causing incorrect behavior.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9003666 -
Flags: review?(jmaher)
|
||
Updated•6 years ago
|
Attachment #9003666 -
Flags: review?(jmaher) → review+
Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e51092dbe3ce [mozdevice] make adb.py _check_adb_root more resilient to differing outputs, r=jmaher.
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e51092dbe3ce
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•