Closed Bug 1485867 Opened 2 years ago Closed 2 years ago

Drop down text is truncated in many places, and content shifts in some places when changing dropdown

Categories

(Toolkit :: Themes, defect, P2)

63 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + verified

People

(Reporter: alice0775, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(4 files)

Attached image screenshot
[Tracking Requested - why for this release]: UI visual regression

Steps To Reproduce:
1. Open about:preferences

Actual Results:
See Attached Screenshot

Expected Results:
Not truncated 


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7311e3026a473a4e4329257e6fd50b38bba6f614&tochange=1c63d5a13deb0998e1c28a1ec4db13d6ed418f23

Regressed by: 1c63d5a13deb	Dão Gottwald — Bug 1481754 - Use inheritance for menu fonts. r=mstriemer


:dao, Can you look into this?
Flags: needinfo?(dao+bmo)
Attached image screenshot
And Content shifts in some places when changing dropdown
Summary: Drop down text is truncated in many places → Drop down text is truncated in many places, and content shifts in some places when changing dropdown
Attached image screenshot
When search term matches, the dropdown will be displayed with line break.
Assignee: nobody → dao+bmo
Component: Preferences → Themes
Flags: needinfo?(dao+bmo)
Priority: -- → P2
See Also: → 1483153
Attached patch patchSplinter Review
Attachment #9003806 - Flags: review?(felipc)
I see this font problem on macOS, too. In particular, I noticed that the "Content process limit" setting's value "4 (default)" is truncated to "4 (defa...".

Also, the "Content process limit" setting's drop down menu uses a smaller font (which can show the full "4 (default)" string) than the value after it has been selected. I don't know if that is a bug or not.
OS: Windows 10 → All
Hardware: x86_64 → All
Attachment #9003806 - Flags: review?(felipc) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88f6a8a83549
Backed out changeset fb2c0eb9ad70 for having the wrong bug number in the commit message
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7377700058
Let menulist popups inherit the font from their menulist parent. r=felipe
https://hg.mozilla.org/mozilla-central/rev/1c7377700058
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Confirmed issue on 63.0a1 (2018-08-28) - win10x64.
*The text fonts - encoding legacy content, was fine in this version on my machine.

Verified the fix on 63.0b11, 64.0a1 on win10x64, macOS 10.13, Ubuntu 16.04 and the issues are no longer reproducible.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.