Closed Bug 1485886 Opened 3 years ago Closed 3 years ago

ReferenceError: MailServices is not defined in attendees dialog

Categories

(Calendar :: Dialogs, defect)

Product:
Calendar
Component:
Dialogs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file, 2 obsolete files)

1485886-mailservices-undefined-3.diff
1.17 KB, patch
MakeMyDay
: review+
Details | Diff | Splinter Review 
Pretty sure I broke this in bug 1480393.
Attachment #9003701 - Flags: review?(makemyday)
Comment on attachment 9003701 [details] [diff] [review]
1485886-mailservices-undefined-1.diff

Review of attachment 9003701 [details] [diff] [review]:
-----------------------------------------------------------------

This mixture of ways to import is unfortunate. Why isn't that needed for Services.jsm or Preferences.jsm?
Attachment #9003701 - Flags: review?(makemyday) → review+
It's not strictly needed for MailServices either, but it lets the linter know what variables we have. It assumes we get Services from Services.jsm and Preferences from Preferences.jsm, which we do. But somebody foolishly named mailServices.js with a lowercase m, which doesn't match the uppercase M on the variable.
Keywords: checkin-needed
Actually, don't check this in. I'm going to fix the real problem instead. Bug 1487572.
Depends on: 1487572
Keywords: checkin-needed
Blocks: 1484636
Assuming mailServices.js gets renamed, we'll still need to fix this bug.
Comment on attachment 9005530 [details] [diff] [review]
1485886-mailservices-undefined-2.diff

I'm an idiot.
Attachment #9005530 - Attachment is obsolete: true
Back to square one. If MailServices has an uppercase M, we don't have to tell ESLint about it. Which is good, because if we try to put it in the .js file, we DO have to tell ESLint about it, because of some weird conflict in rules. Wasting my time.
Attachment #9003701 - Attachment is obsolete: true
Attachment #9005588 - Flags: review?(makemyday)
Attachment #9005588 - Flags: review?(makemyday) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ca3c82931782
Fix missing MailServices in attendees dialog. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.5
You need to log in before you can comment on or make changes to this bug.