Closed Bug 1485901 Opened Last year Closed Last year

Internationalize new about:debugging panels

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(2 files, 1 obsolete file)

As discussed, we want to use react-fluent for this but put the data files outside the usual locale folder until the strings stabilize.
Attached patch WIP patch (obsolete) — Splinter Review
Julian is this more or less what you had in mind?

It's based pretty heavily on the Application panel setup.

It seems to work for me, including the pseudolocalization.

If this seems like the right approach I'll go ahead and localize the other strings we have.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
I'm just going to put this initial patch up for review now. I'll i18n the remaining strings as a separate patch/bug.
Attachment #9003710 - Attachment is obsolete: true
https://treeherder.mozilla.org/#/jobs?repo=try&revision=627b76d8625439e1312a46e47832c2ae87d10815

(I totally forgot to run this last week so there's every chance it could fail.)
Comment on attachment 9004745 [details]
Bug 1485901 - Add localization plumbing for new about:debugging panels; r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9004745 - Flags: review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8031da3e4c91
Add localization plumbing for new about:debugging panels; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/8031da3e4c91
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Note, we've got this hook because we don't expect folks to get fluent files right from the get-go.

Please make sure your temporary file doesn't show up in the file history of the final file, as that will break l10n toolchains. In particular, we have automation that replays history of files moved in to l10n, and this may or may not break with an unsupported file format like tmpftl.
(In reply to Axel Hecht [:Pike] from comment #8)
> Please make sure your temporary file doesn't show up in the file history of
> the final file, as that will break l10n toolchains. In particular, we have
> automation that replays history of files moved in to l10n, and this may or
> may not break with an unsupported file format like tmpftl.

Ok, good idea. I've filed bug 1487581 and made a note of that. Thanks!
Comment on attachment 9005571 [details]
Bug 1485901 - Don't add aboutdebugging locale source if it has already been added; r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9005571 - Flags: review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcae3a9fe7b7
Don't add aboutdebugging locale source if it has already been added; r=jdescottes
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.