1485929 - Split HTMLEditor::RefreshInlineTableEditingUI() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05f91ff766948ebbbeb3305a9f8893af83396fff

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1485929 - Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use

HTMLEditor::RefreshInlineTableEditingUI() is an XPCOM method.  Therefore,
we should create a non-virtual method for internal use.

Additionally, this patch makes related methods safer for nested calls of
ShowInlineTableEditingUI() and HideInlineTableEditingUI().  If
ShowInlineTableEditingUI() and RefreshInlineTableEditingUIInternal() detects
hiding or replacing current UI, they return error to make the callers stop
handling anything for new UI.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 9007769 [details]
Bug 1485929 - Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use

Makoto Kato [:m_kato] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acbe78a8fb89
Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use r=m_kato

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/acbe78a8fb89