Closed Bug 1485929 Opened Last year Closed Last year

Split HTMLEditor::RefreshInlineTableEditingUI() for internal use

Categories

(Core :: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

Priority: -- → P3
HTMLEditor::RefreshInlineTableEditingUI() is an XPCOM method.  Therefore,
we should create a non-virtual method for internal use.

Additionally, this patch makes related methods safer for nested calls of
ShowInlineTableEditingUI() and HideInlineTableEditingUI().  If
ShowInlineTableEditingUI() and RefreshInlineTableEditingUIInternal() detects
hiding or replacing current UI, they return error to make the callers stop
handling anything for new UI.
Comment on attachment 9007769 [details]
Bug 1485929 - Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use

Makoto Kato [:m_kato] has approved the revision.
Attachment #9007769 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/acbe78a8fb89
Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use r=m_kato
https://hg.mozilla.org/mozilla-central/rev/acbe78a8fb89
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.