Closed
Bug 1485929
Opened 6 years ago
Closed 6 years ago
Split HTMLEditor::RefreshInlineTableEditingUI() for internal use
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
No description provided.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05f91ff766948ebbbeb3305a9f8893af83396fff
Assignee | ||
Comment 2•6 years ago
|
||
HTMLEditor::RefreshInlineTableEditingUI() is an XPCOM method. Therefore, we should create a non-virtual method for internal use. Additionally, this patch makes related methods safer for nested calls of ShowInlineTableEditingUI() and HideInlineTableEditingUI(). If ShowInlineTableEditingUI() and RefreshInlineTableEditingUIInternal() detects hiding or replacing current UI, they return error to make the callers stop handling anything for new UI.
Comment 3•6 years ago
|
||
Comment on attachment 9007769 [details] Bug 1485929 - Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use Makoto Kato [:m_kato] has approved the revision.
Attachment #9007769 -
Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/acbe78a8fb89 Create HTMLEditor::RefreshInlineTableEditingUIInternal() for internal use r=m_kato
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/acbe78a8fb89
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•