Closed
Bug 1485935
Opened 6 years ago
Closed 6 years ago
Make HTMLEditor::GetIsCSSEnabled() implemented with NS_IMETODIMP rather than nsresult
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3f08570126a8bd31b5c3a4dac31c21e749d88ba
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eacaaec50ad56d75938536af72bf18f9f5549ffb
|
|
Assignee | |
Comment 3•6 years ago
|
||
Even though HTMLEditor::GetIsCSSEnabled() is an implementation of an XPCOM method, it uses nsresult as its return type. We should change it to NS_IMETHODIMP. Additionally, SetDocumentStateCommand::GetCommandStateParams() calls this, but HTMLEditor can expose non-virtual method, HTMLEditor::IsCSSEnabled(). Therefore, this patch makes it public and makes SetDocumentStateCommand use HTMLEditor::IsCSSEnabled().
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9004129 [details] Bug 1485935 - Use NS_IMETHODIMP for implementation of HTMLEditor::GetIsCSSEnabled() Makoto Kato [:m_kato] has approved the revision.
Attachment #9004129 -
Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/71525c253ed0 Use NS_IMETHODIMP for implementation of HTMLEditor::GetIsCSSEnabled() r=m_kato
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/71525c253ed0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•