Closed
Bug 1485943
Opened 6 years ago
Closed 6 years ago
AlternateServices.cpp writes past the logical length of the string
Categories
(Core :: Networking: HTTP, enhancement, P2)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
AlternateServices.cpp shouldn't use BeginWriting() to write past the logical length of a string. See bug 1484668 for details. The API pending review in bug 1482828 would be a suitable replacement.
|
Assignee | |
Comment 1•6 years ago
|
||
Specifically here: https://searchfox.org/mozilla-central/source/netwerk/protocol/http/AlternateServices.cpp#774
|
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Priority: -- → P2
Whiteboard: [necko-triaged]
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
MozReview-Commit-ID: 4xPYaAbGaEI
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9004776 [details] Bug 1485943 - Avoid writing past the logical length of a string in AlternateServices.cpp. Dragana Damjanovic [:dragana] has approved the revision.
Attachment #9004776 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79ff858fea6b Avoid writing past the logical length of a string in AlternateServices.cpp. r=dragana
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/79ff858fea6b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•