Closed Bug 1485943 Opened Last year Closed Last year

AlternateServices.cpp writes past the logical length of the string

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

AlternateServices.cpp shouldn't use BeginWriting() to write past the logical length of a string. See bug 1484668 for details.

The API pending review in bug 1482828 would be a suitable replacement.
Blocks: 1472113
No longer blocks: 1484990
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Comment on attachment 9004776 [details]
Bug 1485943 - Avoid writing past the logical length of a string in AlternateServices.cpp.

Dragana Damjanovic [:dragana] has approved the revision.
Attachment #9004776 - Flags: review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79ff858fea6b
Avoid writing past the logical length of a string in AlternateServices.cpp. r=dragana
https://hg.mozilla.org/mozilla-central/rev/79ff858fea6b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.