1485947 - Exception - no active filterer but we want one.

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Axel Grude]

On Startup, I see the following error trace in the log:

Error: Caught Exception Error: There is no active filterer but we want one.
errorWithDebug@resource:///modules/errUtils.js:72:10
get activeFilterer@chrome://messenger/content/quickFilterBar.js:530:11
appendTerms@resource://expressionsearch/ExpressionSearchFilter.js:380:17
MFM_createSearchTerms@resource:///modules/quickFilterManager.js:510:11
MFS_createSearchTerms@resource:///modules/quickFilterManager.js:156:12
QFBM_updateSearch@chrome://messenger/content/quickFilterBar.js:588:7
QFBM_onTabRestored@chrome://messenger/content/quickFilterBar.js:429:5
openTab@chrome://messenger/content/tabmail.xml:579:15
restoreTab@chrome://messenger/content/mailTabs.js:244:13
QuickFolders_PrepareSessionStore/mailTabType.modes.folder.restoreTab@chrome://quickfolders/content/quickfolders.js:521:4
restoreTab@chrome://messenger/content/tabmail.xml:1000:11
restoreTabs@chrome://messenger/content/tabmail.xml:1024:18
atStartupRestoreTabs@chrome://messenger/content/msgMail3PaneWindow.js:688:5

My Addon (QuickFolders) wraps restoreTab in order to store a "selected Category string" for every 3pane tab - it is added as tabInfo.QuickFoldersCategory. Why this requires a filterer to be set is unclear to me.

There is probably a better way to implement this, here is the current code:

// overwrite restoreTab
let orgRestore = mailTabType.modes["folder"].restoreTab; // we might have to use QuickFolders.Util.mailFolderTypeName instead "folder" for SeaMonkey
mailTabType.modes["folder"].restoreTab = function(aTabmail, aPersistedState) {
  orgRestore(aTabmail, aPersistedState);
  let rdf = Components.classes['@mozilla.org/rdf/rdf-service;1'].getService(Components.interfaces.nsIRDFService),
      folder = rdf.GetResource(aPersistedState.folderURI).QueryInterface(Components.interfaces.nsIMsgFolder);
  if (folder && aPersistedState.QuickFoldersCategory) {
    let tabInfo, theUri;
    // Thunderbird only code, so it is fine to use tabInfo here:
    for (let i = 0; i < aTabmail.tabInfo.length; i++)
    {
      tabInfo = aTabmail.tabInfo[i];
      if (tabInfo && tabInfo.folderDisplay && tabInfo.folderDisplay.view && tabInfo.folderDisplay.view.displayedFolder) {
        theUri = tabInfo.folderDisplay.view.displayedFolder.URI;
        if (theUri == aPersistedState.folderURI) {
          tabInfo.QuickFoldersCategory = aPersistedState.QuickFoldersCategory;
          return;
        }
      }
    }
  }
}

Comment 1

[Axel Grude]

Attachment: qf_sessionstore.js

More context, here is the complete object and the way it is being called (a global timeout of 5000ms which is ugly as well). Not sure what the correct point of time for this is; I guess I could move it into QuickFOlders instantiation routine and restore the Categories manually there on startup to work around the bug. What's the best approach for expanding the tab restore functionality?

The error is thrown when

  orgRestore(aTabmail, aPersistedState);

is called. (line 44 of attached code)

Comment 2

[Wayne Mery (:wsmwk)]

What is the way forward for this?

Comment 3

[Geoff Lankow (:darktrojan)]

appendTerms@resource://expressionsearch/ExpressionSearchFilter.js:380:17

Maybe try it without Expression Search running?

Comment 4

[Wayne Mery (:wsmwk)]

Axel, is this still an issue for you?

Comment 5

[Axel Grude]

I haven't seen this bug in a long time, so I presume it is fixed