1485949 - Clang-Plugin Build is busted on native MacOS builds.

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Unfortunately our build time static-analysis based on clang is busted on MacOS native builds, this is due because of [1]. The output that we get is:

 0:15.20 ==============================
 0:15.20 FATAL ERROR PROCESSING MOZBUILD FILE
 0:15.20 ==============================
 0:15.20
 0:15.20 The error occurred while processing the following file:
 0:15.20
 0:15.20     /Users/abpostelnicu/Projects/mozilla/mozilla-unified/build/clang-plugin/moz.build
 0:15.20
 0:15.20 The error was triggered on line 71 of this file:
 0:15.20
 0:15.20     HOST_LDFLAGS += ['-lc++']
 0:15.20
 0:15.20 The underlying problem is an attempt to read a reserved UPPERCASE variable that does not exist.
 0:15.20
 0:15.20 The variable read causing the error is:
 0:15.20
 0:15.20     HOST_LDFLAGS
 0:15.20
 0:15.20 Maybe you meant HOST_CFLAGS or HOST_CXXFLAGS?
 0:15.20
 0:15.20 Please change the file to not use this variable.
 0:15.20
 0:15.20 For reference, the set of valid variables is:
 0:15.20
 0:15.20 A11Y_MANIFESTS, ANDROID_INSTRUMENTATION_MANIFESTS, ASFLAGS, ASM_FLAGS, BROWSER_CHROME_MANIFESTS, CFLAGS, CMFLAGS, CMMFLAGS, COMPILE_FLAGS, CONFIGURE_DEFINE_FILES, CONFIGURE_SUBST_FILES, CPP_UNIT_TESTS, CRAMTEST_MANIFESTS, CRASHTEST_MANIFESTS, CXXFLAGS, DEFFILE, DEFINES, DELAYLOAD_DLLS, DIRS, DIST_INSTALL, DIST_SUBDIR, EXPORTS, EXTRA_DSO_LDOPTS, FILES_PER_UNIFIED_FILE, FINAL_LIBRARY, FINAL_TARGET, FINAL_TARGET_FILES, FINAL_TARGET_PP_FILES, FIREFOX_UI_FUNCTIONAL_MANIFESTS, FIREFOX_UI_UPDATE_MANIFESTS, FORCE_SHARED_LIB, FORCE_STATIC_LIB, GENERATED_EVENTS_WEBIDL_FILES, GENERATED_FILES, GENERATED_WEBIDL_FILES, GN_DIRS, GYP_DIRS, HAS_MISC_RULE, HOST_CFLAGS, HOST_COMPILE_FLAGS, HOST_CXXFLAGS, HOST_DEFINES, HOST_LIBRARY_NAME, HOST_OS_LIBS, HOST_PROGRAM, HOST_RUST_LIBRARY_FEATURES, HOST_RUST_PROGRAMS, HOST_SIMPLE_PROGRAMS, HOST_SOURCES, HOST_USE_LIBS, IPDL_SOURCES, IS_FRAMEWORK, IS_RUST_LIBRARY, JAR_MANIFESTS, LDFLAGS, LIBRARY_DEFINES, LIBRARY_NAME, LINK_FLAGS, LOCALIZED_FILES, LOCALIZED_GENERATED_FILES, LOCALIZED_PP_FILES, LOCAL_INCLUDES, MARIONETTE_LAYOUT_MANIFESTS, MARIONETTE_UNIT_MANIFESTS, METRO_CHROME_MANIFESTS, MOCHITEST_CHROME_MANIFESTS, MOCHITEST_MANIFESTS, NO_COMPONENTS_MANIFEST, NO_EXPAND_LIBS,NO_JS_MANIFEST, NO_PGO, OBJDIR_FILES, OBJDIR_PP_FILES, OS_LIBS, PREPROCESSED_IPDL_SOURCES, PREPROCESSED_TEST_WEBIDL_FILES, PREPROCESSED_WEBIDL_FILES, PROGRAM, PUPPETEER_FIREFOX_MANIFESTS, PYTHON_UNITTEST_MANIFESTS, RCFILE, RCINCLUDE, REFTEST_MANIFESTS, RESFILE, RUST_LIBRARY_FEATURES, RUST_LIBRARY_OUTPUT_CATEGORY, RUST_LIBRARY_TARGET_DIR, RUST_PROGRAMS, RUST_TESTS, RUST_TEST_FEATURES, SHARED_LIBRARY_NAME, SHARED_LIBRARY_OUTPUT_CATEGORY, SIMPLE_PROGRAMS, SONAME, SOURCES, SPHINX_PYTHON_PACKAGE_DIRS, SPHINX_TREES, STATIC_LIBRARY_NAME, SYMBOLS_FILE, TEST_HARNESS_FILES, TEST_WEBIDL_FILES, UNIFIED_SOURCES, USE_EXTENSION_MANIFEST, USE_LIBS, USE_STATIC_LIBS, USE_YASM, WEBIDL_EXAMPLE_INTERFACES, WEBIDL_FILES, WEBRTC_SIGNALLING_TEST_MANIFESTS, WEB_PLATFORM_TESTS_MANIFESTS, WIN32_EXE_LDFLAGS, XPCSHELL_TESTS_MANIFESTS, XPIDL_MODULE, XPIDL_SOURCES, XPI_NAME
 0:15.22
 0:15.24 *** Fix above errors and then restart with               "/Applications/Xcode.app/Contents/Developer/usr/bin/make -f client.mk build"
 0:15.24 make: *** [configure] Error 1

Looking other the flags that are used for Darwin we only need: HOST_CXXFLAGS 

[1] https://dxr.mozilla.org/mozilla-central/source/build/clang-plugin/moz.build#71

Comment 1

[Andi [:andi]]

Attachment: Bug 1485949 - fix busted build of clang-plugin on MacOS native build. r=glandium

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 9003763 [details]
Bug 1485949 - fix busted build of clang-plugin on MacOS native build. r=glandium

Mike Hommey [:glandium] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de8a729b3b5f
fix busted build of clang-plugin on MacOS native build. r=glandium

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/de8a729b3b5f