Closed Bug 1486018 Opened 2 years ago Closed 2 years ago

Default additional_images alignment should be top right

Categories

(WebExtensions :: Themes, defect, P1)

defect

Tracking

(firefox-esr52 unaffected, firefox-esr6062+ verified, firefox61 unaffected, firefox62+ verified, firefox63+ verified)

VERIFIED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 62+ verified
firefox61 --- unaffected
firefox62 + verified
firefox63 + verified

People

(Reporter: mconca, Assigned: ntim)

References

Details

(Keywords: regression, Whiteboard: [blocking-static-themes-fx][ntim-intern-project] )

Attachments

(2 files)

Bug 1443561 fixed the alignment of additional_images to be relative to the toolbox, but introduced a new bug causing additional_images to now be aligned to the "left top".  Prior to that patch landing, images were always aligned to the "right top".

The expectation is that all theme backgrounds, headerURL and additional_images, are aligned "top right" in the absence of any additional_backgrounds_alignment key.
Flags: needinfo?(ntim.bugs)
Priority: -- → P1
Blocks: 1443561
Flags: needinfo?(ntim.bugs)
Assignee: nobody → ntim.bugs
Whiteboard: [blocking-static-themes-fx][ntim-intern-project]
Attachment #9003877 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a668b1f8527b
Make additional_backgrounds_alignment default to right top. r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a668b1f8527b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Verified fixed in Nightly 63.0a1 (20180826220129) with Win10x64 and macOS High Sierra 10.13.2

Installed theme: https://addons-dev.allizom.org/en-US/firefox/addon/st-no-align-recheck/
Status: RESOLVED → VERIFIED
Comment on attachment 9003877 [details] [diff] [review]
Make additional_backgrounds_alignment default to right top



Approval Request Comment
[Feature/Bug causing the regression]: bug 1443561
[User impact if declined]: Behaviour change in theme API
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: already done 
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: simple change
[String changes made/needed]: none
Attachment #9003877 - Flags: approval-mozilla-esr60?
Attachment #9003877 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Comment on attachment 9003877 [details] [diff] [review]
Make additional_backgrounds_alignment default to right top

Fixes a regression from bug 1443561. Approved for 62 RC1 and ESR 60.2.
Attachment #9003877 - Flags: approval-mozilla-release+
Attachment #9003877 - Flags: approval-mozilla-esr60?
Attachment #9003877 - Flags: approval-mozilla-esr60+
Attachment #9003877 - Flags: approval-mozilla-beta?
Verified fixed with Firefox 62.0 (20180827144429) with Win10x64 and macOS High Sierra 10.13.2.
Flags: qe-verify+ → qe-verify-
Forgot to mention in the last comment that the issue is verified also with Firefox 60.2.0esr (20180827170958)
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.