Closed
Bug 1486018
Opened 6 years ago
Closed 6 years ago
Default additional_images alignment should be top right
Categories
(WebExtensions :: Themes, defect, P1)
WebExtensions
Themes
Tracking
(firefox-esr52 unaffected, firefox-esr6062+ verified, firefox61 unaffected, firefox62+ verified, firefox63+ verified)
VERIFIED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | 62+ | verified |
| firefox61 | --- | unaffected |
| firefox62 | + | verified |
| firefox63 | + | verified |
People
(Reporter: mconca, Assigned: ntim)
References
Details
(Keywords: regression, Whiteboard: [blocking-static-themes-fx][ntim-intern-project] )
Attachments
(2 files)
|
3.41 KB,
patch
|
dao
:
review+
RyanVM
:
approval-mozilla-release+
RyanVM
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
|
115.83 KB,
image/png
|
Details |
fixed_-_default_top_right_align.png
Bug 1443561 fixed the alignment of additional_images to be relative to the toolbox, but introduced a new bug causing additional_images to now be aligned to the "left top". Prior to that patch landing, images were always aligned to the "right top". The expectation is that all theme backgrounds, headerURL and additional_images, are aligned "top right" in the absence of any additional_backgrounds_alignment key.
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Priority: -- → P1
|
||
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → affected
status-firefox63:
--- → affected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → affected
tracking-firefox62:
--- → +
tracking-firefox63:
--- → +
tracking-firefox-esr60:
--- → 62+
Keywords: regression
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → ntim.bugs
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [blocking-static-themes-fx][ntim-intern-project]
|
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9003877 -
Flags: review?(dao+bmo)
|
||
Updated•6 years ago
|
Attachment #9003877 -
Flags: review?(dao+bmo) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a668b1f8527b Make additional_backgrounds_alignment default to right top. r=dao
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a668b1f8527b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Comment 4•6 years ago
|
||
Verified fixed in Nightly 63.0a1 (20180826220129) with Win10x64 and macOS High Sierra 10.13.2 Installed theme: https://addons-dev.allizom.org/en-US/firefox/addon/st-no-align-recheck/
Status: RESOLVED → VERIFIED
|
|
||
Updated•6 years ago
|
|
|
||
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
Comment on attachment 9003877 [details] [diff] [review] Make additional_backgrounds_alignment default to right top Approval Request Comment [Feature/Bug causing the regression]: bug 1443561 [User impact if declined]: Behaviour change in theme API [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: already done [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: low risk [Why is the change risky/not risky?]: simple change [String changes made/needed]: none
Attachment #9003877 -
Flags: approval-mozilla-esr60?
Attachment #9003877 -
Flags: approval-mozilla-beta?
|
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9003877 [details] [diff] [review] Make additional_backgrounds_alignment default to right top Fixes a regression from bug 1443561. Approved for 62 RC1 and ESR 60.2.
Attachment #9003877 -
Flags: approval-mozilla-release+
Attachment #9003877 -
Flags: approval-mozilla-esr60?
Attachment #9003877 -
Flags: approval-mozilla-esr60+
Attachment #9003877 -
Flags: approval-mozilla-beta?
|
|
||
Comment 8•6 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/1e90245c4cb3 (FIREFOX_62b_RELBRANCH) https://hg.mozilla.org/releases/mozilla-release/rev/6682c198a233
|
|
||
Comment 9•6 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-esr60/rev/a8e3e6431942
|
|
||
Comment 10•6 years ago
|
||
Verified fixed with Firefox 62.0 (20180827144429) with Win10x64 and macOS High Sierra 10.13.2.
|
|
||
Updated•6 years ago
|
Flags: qe-verify+ → qe-verify-
|
|
||
Comment 11•6 years ago
|
||
Forgot to mention in the last comment that the issue is verified also with Firefox 60.2.0esr (20180827170958)
You need to log in
before you can comment on or make changes to this bug.
Description
•