1486018 - Default additional_images alignment should be top right

Status: VERIFIED FIXED

(WebExtensions :: Themes, defect, P1)

Description

[Mike Conca [:mconca]]

Bug 1443561 fixed the alignment of additional_images to be relative to the toolbox, but introduced a new bug causing additional_images to now be aligned to the "left top".  Prior to that patch landing, images were always aligned to the "right top".

The expectation is that all theme backgrounds, headerURL and additional_images, are aligned "top right" in the absence of any additional_backgrounds_alignment key.

Comment 1

[Tim Nguyen :ntim]

Attachment: Make additional_backgrounds_alignment default to right top

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a668b1f8527b
Make additional_backgrounds_alignment default to right top. r=dao

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a668b1f8527b

Comment 4

[Alexandra Moga [:LexaSV]]

Verified fixed in Nightly 63.0a1 (20180826220129) with Win10x64 and macOS High Sierra 10.13.2

Installed theme: https://addons-dev.allizom.org/en-US/firefox/addon/st-no-align-recheck/

Comment 5

[Alexandra Moga [:LexaSV]]

Attachment: fixed_-_default_top_right_align.png

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 9003877 [details] [diff] [review]
Make additional_backgrounds_alignment default to right top



Approval Request Comment
[Feature/Bug causing the regression]: bug 1443561
[User impact if declined]: Behaviour change in theme API
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: already done 
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: simple change
[String changes made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9003877 [details] [diff] [review]
Make additional_backgrounds_alignment default to right top

Fixes a regression from bug 1443561. Approved for 62 RC1 and ESR 60.2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1e90245c4cb3 (FIREFOX_62b_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/6682c198a233

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/a8e3e6431942

Comment 10

[Alexandra Moga [:LexaSV]]

Verified fixed with Firefox 62.0 (20180827144429) with Win10x64 and macOS High Sierra 10.13.2.

Comment 11

[Alexandra Moga [:LexaSV]]

Forgot to mention in the last comment that the issue is verified also with Firefox 60.2.0esr (20180827170958)