Closed
Bug 1486027
Opened 7 years ago
Closed 7 years ago
don't oom on failed ModuleGenerator memory reservations
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file, 1 obsolete file)
|
3.13 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
To avoid realloc costs, ModuleGenerator performs some conservative (slightly over-sized) memory reservations, based on declarations in the ModuleEnvironment. If these fail, however, we currently report oom when the actual compilation might succeed. On 32-bit, we have one such case atm that succeeds when the masm.reserve() failure is ignored (151mb reserved, but only 112mb needed).
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → luke
Attachment #9003844 -
Flags: review?(bbouvier)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Oops, that had some printf()s.
Attachment #9003844 -
Attachment is obsolete: true
Attachment #9003844 -
Flags: review?(bbouvier)
Attachment #9003845 -
Flags: review?(bbouvier)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 9003845 [details] [diff] [review]
fix-reservation
Review of attachment 9003845 [details] [diff] [review]:
-----------------------------------------------------------------
Ha, good catch.
Attachment #9003845 -
Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b48d2197a9a0
don't oom on failed ModuleGenerator memory reservations (r=bbouvier)
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•