Closed Bug 1486039 Opened 1 year ago Closed 1 year ago

fix SpinEvent.cpp for aarch64 Windows

Categories

(Core :: IPC: MSCOM, enhancement)

ARM64
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The pause intrinsic isn't really a thing on AArch64 Windows, but we can just use YieldProcessor instead, which is more portable.
YieldProcessor is apparently defined to do the same thing on x86 as our
custom macros, but includes implementations for non-x86 processors.
Attachment #9003851 - Flags: review?(aklotz)
Attachment #9003851 - Flags: review?(aklotz) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3568c72a41cc
use a more-portable idiom for pausing in SpinEvent::Wait; r=aklotz
https://hg.mozilla.org/mozilla-central/rev/3568c72a41cc
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.