Closed
Bug 1486039
Opened 6 years ago
Closed 6 years ago
fix SpinEvent.cpp for aarch64 Windows
Categories
(Core :: IPC: MSCOM, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.84 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
The pause intrinsic isn't really a thing on AArch64 Windows, but we can just use YieldProcessor instead, which is more portable.
Assignee | ||
Comment 1•6 years ago
|
||
YieldProcessor is apparently defined to do the same thing on x86 as our custom macros, but includes implementations for non-x86 processors.
Attachment #9003851 -
Flags: review?(aklotz)
Updated•6 years ago
|
Attachment #9003851 -
Flags: review?(aklotz) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3568c72a41cc use a more-portable idiom for pausing in SpinEvent::Wait; r=aklotz
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3568c72a41cc
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•