Closed
Bug 1486056
Opened 6 years ago
Closed 6 years ago
fix Skia build for aarch64 windows
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
(Whiteboard: gfx-noted)
Attachments
(1 file)
2.14 KB,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
Trying to assemble X86-ish code on AArch64 isn't going to end well: 0:24.53 Microsoft (R) ARM Macro Assembler Version 14.15.26720.0 for 64 bits 0:24.54 Copyright (C) Microsoft Corporation. All rights reserved. 0:24.54 error A2029: unknown command-line argument or argument value -DNDEBUG=1 0:24.54 Usage: armasm [<options>] sourcefile objectfile 0:24.54 armasm [<options>] -o objectfile sourcefile 0:24.54 armasm -h for help 0:24.55 mozmake.EXE[4]: *** [c:/mozilla-central/config/rules.mk:1103: SkJumper_generated_win.obj] Error 1 0:24.56 mozmake.EXE[3]: *** [c:/mozilla-central/config/recurse.mk:74: gfx/skia/target] Error 2 0:24.56 mozmake.EXE[3]: *** Waiting for unfinished jobs.... (This is a simple invocation error, but the file is full of bytes translating to x86 machine code...) Lee, do you know if Skia upstream is including support for AArch64? It's possible my tree is slightly out of date...
Flags: needinfo?(lsalzman)
Assignee | ||
Comment 1•6 years ago
|
||
Apparently the SkJumper_generated_win code isn't actually necessary?
Assignee | ||
Comment 2•6 years ago
|
||
Compiling a blob of x86 machine code is not going to end well.
Attachment #9003891 -
Flags: review?(lsalzman)
Updated•6 years ago
|
Flags: needinfo?(lsalzman)
Attachment #9003891 -
Flags: review?(lsalzman) → review+
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: gfx-noted
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b799a3ca903e don't compile SkJumper_generated_win.S on aarch64 windows; r=lsalzman
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b799a3ca903e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•