Crash in mozilla::extensions::URLInfo::CSpec const

RESOLVED FIXED in Firefox 63

Status

defect
--
critical
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: calixte, Assigned: kmag)

Tracking

(Blocks 1 bug, {crash, regression})

unspecified
mozilla63
Unspecified
All
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 unaffected, firefox63+ fixed)

Details

(crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is
report bp-f5bb0a2d-04c3-40ce-8ce2-b0ed00180824.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::extensions::URLInfo::CSpec const toolkit/components/extensions/MatchPattern.cpp:174
1 libxul.so mozilla::extensions::URLInfo::Spec const toolkit/components/extensions/MatchPattern.cpp:183
2 libxul.so mozilla::extensions::MozDocumentMatcher::Matches const toolkit/components/extensions/MatchPattern.cpp:205
3 libxul.so mozilla::ExtensionPolicyService::InjectContentScripts const [clone .cold.289] 
4 libxul.so mozilla::ForEachDocShell gcc/include/c++/6.4.0/functional:2127
5 libxul.so mozilla::ExtensionPolicyService::InjectContentScripts toolkit/components/extensions/ExtensionPolicyService.cpp:421
6 libxul.so mozilla::extensions::WebExtensionPolicy::InjectContentScripts toolkit/components/extensions/WebExtensionPolicy.cpp:337
7 libxul.so mozilla::dom::WebExtensionPolicy_Binding::injectContentScripts dom/bindings/WebExtensionPolicyBinding.cpp:1705
8 libxul.so bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3296
9 libxul.so js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:449

=============================================================

There is 1 crash in nightly 63 with buildid 20180824100112. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1484373.

[1] https://hg.mozilla.org/mozilla-central/rev?node=a7848dcb339e
Flags: needinfo?(kmaglione+bmo)
Crash Signature: [@ mozilla::extensions::URLInfo::CSpec const] → [@ mozilla::extensions::URLInfo::CSpec const] [@ mozilla::extensions::URLInfo::Spec]
Crash Signature: [@ mozilla::extensions::URLInfo::CSpec const] [@ mozilla::extensions::URLInfo::Spec] → [@ mozilla::extensions::URLInfo::CSpec const] [@ mozilla::extensions::URLInfo::Spec] [@ mozilla::extensions::URLInfo::Spec const]
Crash Signature: [@ mozilla::extensions::URLInfo::CSpec const] [@ mozilla::extensions::URLInfo::Spec] [@ mozilla::extensions::URLInfo::Spec const] → [@ mozilla::extensions::URLInfo::CSpec const] [@ mozilla::extensions::URLInfo::Spec] [@ mozilla::extensions::URLInfo::Spec const] [@ mozilla::extensions::URLInfo::CSpec]
OS: Linux → All
Comment on attachment 9004022 [details]
Bug 1486057: Skip uninitialized windows when injecting content scripts. r=mixedpuppy

Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #9004022 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/292e35a4377f5f6c5534dad4f4df349010de41b9
Bug 1486057: Skip uninitialized windows when injecting content scripts. r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/292e35a4377f
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.