Closed Bug 1486061 Opened Last year Closed Last year

Add GeckoView safe browsing tests

Categories

(GeckoView :: General, enhancement, P2)

51 Branch
All
Android
enhancement

Tracking

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → esawin
Attachment #9003849 - Flags: review?(snorp)
Rebased.
Attachment #9003849 - Attachment is obsolete: true
Attachment #9003849 - Flags: review?(snorp)
Attachment #9003876 - Flags: review?(snorp)
Comment on attachment 9003876 [details] [diff] [review]
0001-Bug-1486061-1.1-Add-GeckoView-safe-browsing-tests.-r.patch

We can't have network requests in automation, need to refactor the patch.
Attachment #9003876 - Flags: review?(snorp)
Comment on attachment 9003876 [details] [diff] [review]
0001-Bug-1486061-1.1-Add-GeckoView-safe-browsing-tests.-r.patch

Review of attachment 9003876 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #9003876 - Flags: review+
Rebased and added "www." to the URIs to avoid hitting the network in automation (https://searchfox.org/mozilla-central/source/build/pgo/server-locations.txt#127).
Attachment #9003876 - Attachment is obsolete: true
Attachment #9012733 - Flags: review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3439a7f9f27
[1.1] Add GeckoView safe browsing tests. r=snorp
https://hg.mozilla.org/mozilla-central/rev/b3439a7f9f27
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Eugen says we don't need to uplift these tests to GV 63 Beta.
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.