Closed
Bug 1486061
Opened 6 years ago
Closed 6 years ago
Add GeckoView safe browsing tests
Categories
(GeckoView :: General, enhancement, P2)
Tracking
(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: esawin, Assigned: esawin)
References
Details
Attachments
(1 file, 2 obsolete files)
5.69 KB,
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → esawin
Attachment #9003849 -
Flags: review?(snorp)
Assignee | ||
Comment 2•6 years ago
|
||
Rebased.
Attachment #9003849 -
Attachment is obsolete: true
Attachment #9003849 -
Flags: review?(snorp)
Attachment #9003876 -
Flags: review?(snorp)
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 9003876 [details] [diff] [review] 0001-Bug-1486061-1.1-Add-GeckoView-safe-browsing-tests.-r.patch We can't have network requests in automation, need to refactor the patch.
Attachment #9003876 -
Flags: review?(snorp)
Comment on attachment 9003876 [details] [diff] [review] 0001-Bug-1486061-1.1-Add-GeckoView-safe-browsing-tests.-r.patch Review of attachment 9003876 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #9003876 -
Flags: review+
Updated•6 years ago
|
status-firefox61:
--- → wontfix
status-firefox62:
--- → fix-optional
status-firefox63:
--- → affected
status-firefox-esr52:
--- → wontfix
status-firefox-esr60:
--- → wontfix
Priority: -- → P2
Assignee | ||
Comment 5•6 years ago
|
||
Rebased and added "www." to the URIs to avoid hitting the network in automation (https://searchfox.org/mozilla-central/source/build/pgo/server-locations.txt#127).
Attachment #9003876 -
Attachment is obsolete: true
Attachment #9012733 -
Flags: review+
Pushed by esawin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3439a7f9f27 [1.1] Add GeckoView safe browsing tests. r=snorp
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b3439a7f9f27
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Comment 8•6 years ago
|
||
Eugen says we don't need to uplift these tests to GV 63 Beta.
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Target Milestone: Firefox 64 → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•