Insert initial browser dynamically, to make it possible to set initial remoteness and whether it needs to load about:blank

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 63
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Splitting this off from bug 1362774 because it can happen separately, and helps get this pile of patches landing without bitrotting every time we touch tabbrowser or some of the bindings (and thereby the order in which various bits of initialization happen).
(Assignee)

Comment 2

8 months ago
Try looks pretty green, though I'm retriggering this:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4b44688bc04d7cd5a537f86d138b1de2829c8d1&selectedJob=195778635

because initial focus seems like something that could potentially actually be perma-orange (though then why isn't it failing anywhere else or on debug)?
Comment on attachment 9003864 [details]
Bug 1486079 - create initial browser dynamically so we can set various attributes from the start, r?dao

Dão Gottwald [::dao] has approved the revision.
Attachment #9003864 - Flags: review+
Blocks: 1485908

Comment 4

8 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/05672d13ef56
create initial browser dynamically so we can set various attributes from the start, r=dao
Blocks: 1441935

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/05672d13ef56
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Does this issue needs manual QA testing?
Flags: qe-verify?
(Assignee)

Comment 7

7 months ago
No, I don't think it makes sense to do manual testing here - it's an implementation detail.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.