Closed Bug 1486081 Opened 1 year ago Closed 1 year ago

Update the strings in the Cookies and Site Data UI

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file, 1 obsolete file)

We need to update these strings for consistency with the Content Blocking UI.
Attachment #9003863 - Flags: review?(francesco.lodolo)
Comment on attachment 9003863 [details] [diff] [review]
Update the strings in the Cookies and Site Data UI

Review of attachment 9003863 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/browser/preferences/preferences.ftl
@@ +755,4 @@
>      .accesskey = T
>  
>  sitedata-block-trackers-option-recommended =
>      .label = Third party trackers (recommended)

Should we fix these two "Third party" since we're touching the file? As said, for these two you wouldn't need a new ID.

@@ +765,1 @@
>  sitedata-block-always-option =

This one needs a new ID, since the string is changing (in Fluent, that includes any attribute change).
Attachment #9003863 - Flags: review?(francesco.lodolo) → review-
(In reply to Francesco Lodolo [:flod] from comment #2)
> Comment on attachment 9003863 [details] [diff] [review]
> Update the strings in the Cookies and Site Data UI
> 
> Review of attachment 9003863 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/locales/en-US/browser/preferences/preferences.ftl
> @@ +755,4 @@
> >      .accesskey = T
> >  
> >  sitedata-block-trackers-option-recommended =
> >      .label = Third party trackers (recommended)
> 
> Should we fix these two "Third party" since we're touching the file? As
> said, for these two you wouldn't need a new ID.

Sure, thanks for reminding me!

> @@ +765,1 @@
> >  sitedata-block-always-option =
> 
> This one needs a new ID, since the string is changing (in Fluent, that
> includes any attribute change).

OK, makes sense.
We need to update these strings for consistency with the Content Blocking UI.
Attachment #9003966 - Flags: review?(francesco.lodolo)
Attachment #9003863 - Attachment is obsolete: true
Comment on attachment 9003966 [details] [diff] [review]
Update the strings in the Cookies and Site Data UI

Review of attachment 9003966 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks
Attachment #9003966 - Flags: review?(francesco.lodolo) → review+
Assignee: nobody → ehsan
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6e996305d3
Update the strings in the Cookies and Site Data UI; r=flod
https://hg.mozilla.org/mozilla-central/rev/bf6e996305d3
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.