Closed
Bug 1486092
Opened 6 years ago
Closed 6 years ago
Make the reject tracker cookie behavior honor the content blocking pref
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(3 files, 3 obsolete files)
5.84 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
6.88 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
17.48 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
This option is being exposed as part of the Content Blocking UI, so we would like to make it honor the same pref as well.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9003921 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•6 years ago
|
||
The semantics implemented are as follows: the feature requires this new pref to also be set to true, otherwise cookies from trackers will be accepted.
Attachment #9003922 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•6 years ago
|
||
The antitracking test mini-framework is extended to run the non-blocking callback of the tests three times, each time with a unique combination of the network.cookie.cookieBehavior and browser.contentblocking.enabled prefs that would cause the reject tracker cookie behavior feature to get disabled. This works seamlessly for all test cases that do not make any assumptions around how many times their callbacks are executed. Note that browser_imageCache.js depends on the number of times its non-blocking callback gets executed. As a result of this, this test is split into three tests to test the three possible combinations of the pref for the non-blocking callback.
Attachment #9003923 -
Flags: review?(amarchesini)
Assignee | ||
Comment 4•6 years ago
|
||
The semantics implemented are as follows: the feature requires this new pref to also be set to true, otherwise cookies from trackers will be accepted.
Attachment #9003925 -
Flags: review?(amarchesini)
Assignee | ||
Updated•6 years ago
|
Attachment #9003922 -
Attachment is obsolete: true
Attachment #9003923 -
Attachment is obsolete: true
Attachment #9003922 -
Flags: review?(amarchesini)
Attachment #9003923 -
Flags: review?(amarchesini)
Assignee | ||
Comment 5•6 years ago
|
||
The antitracking test mini-framework is extended to run the non-blocking callback of the tests three times, each time with a unique combination of the network.cookie.cookieBehavior and browser.contentblocking.enabled prefs that would cause the reject tracker cookie behavior feature to get disabled. This works seamlessly for all test cases that do not make any assumptions around how many times their callbacks are executed. Note that browser_imageCache.js depends on the number of times its non-blocking callback gets executed. As a result of this, this test is split into three tests to test the three possible combinations of the pref for the non-blocking callback.
Attachment #9003926 -
Flags: review?(amarchesini)
Assignee | ||
Comment 6•6 years ago
|
||
The antitracking test mini-framework is extended to run the non-blocking callback of the tests three times, each time with a unique combination of the network.cookie.cookieBehavior and browser.contentblocking.enabled prefs that would cause the reject tracker cookie behavior feature to get disabled. This works seamlessly for all test cases that do not make any assumptions around how many times their callbacks are executed. Note that browser_imageCache.js depends on the number of times its non-blocking callback gets executed. As a result of this, this test is split into three tests to test the three possible combinations of the pref for the non-blocking callback.
Attachment #9003938 -
Flags: review?(amarchesini)
Assignee | ||
Updated•6 years ago
|
Attachment #9003926 -
Attachment is obsolete: true
Attachment #9003926 -
Flags: review?(amarchesini)
Updated•6 years ago
|
Attachment #9003921 -
Flags: review?(amarchesini) → review+
Updated•6 years ago
|
Attachment #9003925 -
Flags: review?(amarchesini) → review+
Updated•6 years ago
|
Attachment #9003938 -
Flags: review?(amarchesini) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/537688d78965 Part 1: Move the browser.contentblocking.enabled pref to StaticPrefs; r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/b6c0d8e69ddc Part 2: Make the reject tracker cookie behavior also depend on the browser.contentblocking.enabled pref; r=baku https://hg.mozilla.org/integration/mozilla-inbound/rev/389b7c456a91 Part 3: Add tests to ensure that the reject tracker cookie behavior also depends on the browser.contentblocking.enabled pref; r=baku
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/537688d78965 https://hg.mozilla.org/mozilla-central/rev/b6c0d8e69ddc https://hg.mozilla.org/mozilla-central/rev/389b7c456a91
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•