Closed Bug 1486119 Opened 2 years ago Closed 2 years ago

Pocket replace getSystemPrincipal opening new tab with createNullPrincipal

Categories

(Firefox :: Pocket, enhancement)

Product:
Firefox
Component:
Pocket
Version:
63 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- verified

People

(Reporter: anthony, Assigned: anthony)

References

Details

Attachments

(1 file)

Pocket: Replace getSystemPrincipal opening new tab with createNullPrincipal
46 bytes, text/x-phabricator-request
jkt
: review+
Gijs
: review+
Details | Review 
Opening a new tab with a hardcoded link with the system utility openWebLinkI was erroring when passing in getSystemPrincipal. Updating code to pass in a createNullPrincipal.
Opening a new tab with a hardcoded link with the system utility openWebLinkI
was erroring when passing in getSystemPrincipal. Updating code to pass in a
createNullPrincipal.
Comment on attachment 9003909 [details]
Pocket: Replace getSystemPrincipal opening new tab with createNullPrincipal

Jonathan Kingston [:jkt] has approved the revision.
Attachment #9003909 - Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e846d4b1012d
Pocket: Replace getSystemPrincipal opening new tab with createNullPrincipal r=jkt
Comment on attachment 9003909 [details]
Pocket: Replace getSystemPrincipal opening new tab with createNullPrincipal

:Gijs (he/him) has approved the revision.
Attachment #9003909 - Flags: review+
Assignee: nobody → anthony
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e846d4b1012d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.