Closed
Bug 1486125
Opened 6 years ago
Closed 6 years ago
JSContext::noGCOrAllocationCheck and its helper methods are unused
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: anba, Assigned: dpino, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
3.04 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
There doesn't seem to be a single caller to JSContext::allowAlloc() and JSContext::disallowAlloc(), so it may make sense to simply remove JSContext::noGCOrAllocationCheck and its helper methods.
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Here's a patch that removes JSContext::noGCOrAllocationCheck and its helper methods.
Attachment #9005885 -
Flags: review?(jcoppeard)
Comment 2•6 years ago
|
||
Comment on attachment 9005885 [details] [diff] [review] Bug-1486125-Remove-JSContext-noGCOrAllocationCheck-a.patch Review of attachment 9005885 [details] [diff] [review]: ----------------------------------------------------------------- You also need to remove the initialisation of noGCOrAllocationCheck in the JSContext constructor in JSContext.cpp. r=me with that change.
Attachment #9005885 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 3•6 years ago
|
||
I amended the patch to include the necessary change in JSContext.cpp. I also modified the patch message to include r=jonco. I don't have commit access, could you help me run the try-server?
Attachment #9005885 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9005980 -
Flags: review+
Comment 4•6 years ago
|
||
Thanks for the update. I pushed the patch to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae44c714fb280b9592ebd385a94427144079905c
Assignee | ||
Comment 5•6 years ago
|
||
It seems the try-server was OK. I would need to add the keyword "checkin-needed" to land it, but I think I cannot do that unless I have permissions to edit the bug.
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e99f6ed6c2f Remove JSContext::noGCOrAllocationCheck and its helper methods. r=jonco
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e99f6ed6c2f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
status-firefox64:
fixed → ---
Target Milestone: mozilla64 → mozilla63
Updated•6 years ago
|
Updated•6 years ago
|
Assignee: nobody → dpino
You need to log in
before you can comment on or make changes to this bug.
Description
•