1486125 - JSContext::noGCOrAllocationCheck and its helper methods are unused

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[André Bargull [:anba]]

There doesn't seem to be a single caller to JSContext::allowAlloc() and JSContext::disallowAlloc(), so it may make sense to simply remove JSContext::noGCOrAllocationCheck and its helper methods.

Comment 1

[Diego Pino]

Attachment: Bug-1486125-Remove-JSContext-noGCOrAllocationCheck-a.patch

Here's a patch that removes JSContext::noGCOrAllocationCheck and its helper methods.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 9005885 [details] [diff] [review]
Bug-1486125-Remove-JSContext-noGCOrAllocationCheck-a.patch

Review of attachment 9005885 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to remove the initialisation of noGCOrAllocationCheck in the JSContext constructor in JSContext.cpp.

r=me with that change.

Comment 3

[Diego Pino]

Attachment: Bug-1486125-Remove-JSContext-noGCOrAllocationCheck-a.patch

I amended the patch to include the necessary change in JSContext.cpp. I also modified the patch message to include r=jonco. I don't have commit access, could you help me run the try-server?

Comment 4

[Jon Coppeard (:jonco)]

Thanks for the update.  I pushed the patch to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae44c714fb280b9592ebd385a94427144079905c

Comment 5

[Diego Pino]

It seems the try-server was OK. I would need to add the keyword "checkin-needed" to land it, but I think I cannot do that unless I have permissions to edit the bug.

Comment 6

[Jon Coppeard (:jonco)]

Done.  Thanks for the patch!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e99f6ed6c2f
Remove JSContext::noGCOrAllocationCheck and its helper methods. r=jonco

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5e99f6ed6c2f