1486130 - Unhandled promise rejections are no longer reported for DOM exceptions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Kris Maglione [:kmag]]

Apparently this was fixed once before, but regressed when we switched to Spidermonkey promises, which I unfortunately did not notice until after I fixed it again.

Our unhandled promise rejection reporter tries to avoid undefined behavior by only reporting rejections for native error objects, so that it doesn't have to access JS properties which might run arbitrary code or bring dying objects back to life. Unfortunately, it only currently handles native JS ErrorObjects, and not DOM/XPC Exceptions.

We probably don't really need this anti-sniffing behavior anymore, since we no longer report unhandled rejections during finalization. But it's just as easy to special case DOM/XPC Exceptions as it is to remove those guards, so I'm going the safe route for now.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug

Comment 2

[Olli Pettay [:smaug]]

Comment on attachment 9003912 [details]
Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ccc1c8a7abeefd54bc4cf9a5d0eef23681c924a
Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee4af6d31e69542f53aee91cb126e3d2a85691de
Bug 1486130: Follow-up: Ignore extra console message on OS-X. r=bustage,test-only

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7ccc1c8a7abe
https://hg.mozilla.org/mozilla-central/rev/ee4af6d31e69