1486157 - Translation image broken in preferences

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Jonathan Kingston [:jkt] he/him]

STR
1. Enable browser.translation.ui.show in about:config
2. Go to about:preferences
3. Go to Languages section
4. Click on Microsoft logo

Expected

Link should open

Actual

Console warning about triggeringPrincipal is shown.

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1486157 - Change language provider attribution to use openWebLinkIn. r?Gijs

Comment 2

[Jonathan Kingston [:jkt] he/him]

Side note: I don't know if this code is even active.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Jonathan Kingston [:jkt] from comment #2)
> Side note: I don't know if this code is even active.

I'm pretty sure it's unmaintained and unowned, and it might not even work anymore. I remember Felipe working on this as an experiment several years ago (beta and 2/3 locales, IIRC), but it never made it out of that phase.

Comment 4

[Francesco Lodolo [:flod]]

Found also https://bugzilla.mozilla.org/show_bug.cgi?id=971044#c2

Comment 5

[:Gijs (he/him)]

Comment on attachment 9003946 [details]
Bug 1486157 - Change language provider attribution to use openWebLinkIn. r?Gijs

:Gijs (he/him) has approved the revision.

Comment 6

[Florian Quèze [:florian]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> (In reply to Jonathan Kingston [:jkt] from comment #2)
> > Side note: I don't know if this code is even active.
> 
> I'm pretty sure it's unmaintained and unowned, and it might not even work
> anymore. I remember Felipe working on this as an experiment several years
> ago (beta and 2/3 locales, IIRC), but it never made it out of that phase.

The code is currently pref'ed off, but there's an active discussion about using it to run another study using Shield 'soon'.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/684d84410d7f
Change language provider attribution to use openWebLinkIn. r=Gijs

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/684d84410d7f