Crash in mozilla::dom::Promise::All

RESOLVED FIXED in Firefox 63

Status

defect
--
critical
RESOLVED FIXED
Last year
11 months ago

People

(Reporter: calixte, Assigned: kmag)

Tracking

(Blocks 1 bug, {crash, regression})

unspecified
mozilla63
Unspecified
Windows 10
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 unaffected, firefox63 fixed)

Details

(crash signature)

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is
report bp-f406241f-e18c-463c-90c3-31fd00180825.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::Promise::All dom/promise/Promise.cpp:162
1 xul.dll class RefPtr<mozilla::dom::Promise> mozilla::ExtensionPolicyService::ExecuteContentScripts toolkit/components/extensions/ExtensionPolicyService.cpp:362
2 xul.dll struct already_AddRefed<mozilla::dom::Promise> mozilla::dom::`anonymous namespace'::NativeThenHandler<`lambda at z:/build/build/src/toolkit/components/extensions/ExtensionPolicyService.cpp:401:7', mozilla::ExtensionPolicyService*, nsCOMPtr<nsPIDOMWindowInner>&, AutoTArray<RefPtr<mozilla::extensions::WebExtensionContentScript>, 8> >::CallResolveCallback dom/promise/Promise-inl.h:113
3 xul.dll mozilla::dom::PromiseNativeThenHandlerBase::ResolvedCallback dom/promise/Promise.cpp:235
4 xul.dll ?ResolvedCallback@PromiseNativeHandlerShim@?A@dom@mozilla@@UEAAXPEAUJSContext@@V?$Handle@TValue@JS@@@JS@@@Z$c5275f10b14907164f39278f694797f8 dom/promise/Promise.cpp:394
5 xul.dll static bool mozilla::dom::NativeHandlerCallback dom/promise/Promise.cpp:343
6 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:537
7 xul.dll static bool InternalCall js/src/vm/Interpreter.cpp:588
8 xul.dll js::Call js/src/vm/Interpreter.cpp:607
9 xul.dll static bool PromiseReactionJob js/src/builtin/Promise.cpp:1542

=============================================================

There is 1 crash in nightly 63 with buildid 20180824222409. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1484373.

[1] https://hg.mozilla.org/mozilla-central/rev?node=a7848dcb339e
Flags: needinfo?(kmaglione+bmo)
Comment on attachment 9004023 [details]
Bug 1486199: Ignore null promises when injecting content scripts. r=mixedpuppy

Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #9004023 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/24a110d82c0f52e757878dbfa7b0c62f2bd0b2fa
Bug 1486199: Ignore null promises when injecting content scripts. r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/24a110d82c0f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.