Closed Bug 1486211 Opened Last year Closed Last year

Remove unused key browser.search.defaultenginename from region.properties

Categories

(Firefox for Android :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

Actually, reassigning the bug, since it looks like there are still several references to browser.search.defaultenginename in mobile's code, and I'm not exactly sure what to do with them.

https://searchfox.org/mozilla-central/rev/1410bb760a5e77236b74999807f5500bd285a57d/mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java#59

https://searchfox.org/mozilla-central/rev/1410bb760a5e77236b74999807f5500bd285a57d/mobile/android/chrome/content/browser.js#1033-1050
Assignee: francesco.lodolo → nobody
Summary: Remove browser.search.defaultenginename from region.properties → Remove ununsed key browser.search.defaultenginename from region.properties
Summary: Remove ununsed key browser.search.defaultenginename from region.properties → Remove unused key browser.search.defaultenginename from region.properties
@mike
Would you have time to look into this? I don't think just removing the pref in region.properties would be smart on my side, but it would be great to fix before the end of 63 cycle on Nightly.
Flags: needinfo?(mozilla)
Yes, you can just remove the pref from region.properties.

https://searchfox.org/mozilla-central/rev/1410bb760a5e77236b74999807f5500bd285a57d/mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java#59

is about reading the pref from a distribution only.

https://searchfox.org/mozilla-central/rev/1410bb760a5e77236b74999807f5500bd285a57d/mobile/android/chrome/content/browser.js#1033-1050

is a migration of the preference that happened a long time ago.

So you can safely remove it from region.properties.
Flags: needinfo?(mozilla)
Assignee: nobody → francesco.lodolo
(In reply to Mike Kaply [:mkaply] from comment #3)
> So you can safely remove it from region.properties.

Thanks for taking a look, patch incoming.
Comment on attachment 9004461 [details]
Bug 1486211 - Remove unused key browser.search.defaultenginename from region.properties

Mike Kaply [:mkaply] has approved the revision.
Attachment #9004461 - Flags: review+
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/14348a5743c9
Remove unused key browser.search.defaultenginename from region.properties r=mkaply
https://hg.mozilla.org/mozilla-central/rev/14348a5743c9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.