Closed
Bug 1486236
Opened 7 years ago
Closed 7 years ago
UITests: Tests are not compiling due to error: cannot call value of non-function type 'String'
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
Details
Attachments
(1 file)
UI tests on master are not compiling due to this error:
UITests/SessionRestoreTests.swift:[31,43] cannot call value of non-function type 'String'
Please see full log here:
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5b7e071005ec7200015626bf#logs
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 9004070 [details] [review]
Pull Request
Tests are passing on BB, but for some reason (unlikely related to the tests) there is a retry and there is when the tests fail. I think this can be reviewed and if ok landed to have the UI tests back
Attachment #9004070 -
Flags: review?(npark)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Please see logs:
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5b83d879d0984a0001d294a8#logs
Line #6719
|
|
Assignee | |
Comment 4•7 years ago
|
||
After re-launching tests on BB, build is green: https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5b83e46f7dc9930001803d4d#tests
|
||
Updated•7 years ago
|
Attachment #9004070 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/0b0ba7c5611212be1229f0519e9a6c274d7dfe75
So far this has not been seen on v13.x so no uplift so far needed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•