Closed
Bug 1486252
Opened 6 years ago
Closed 6 years ago
CSS property `mask-image` does work with SVG fragment
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | wontfix |
| firefox61 | --- | wontfix |
| firefox62 | --- | wontfix |
| firefox63 | --- | fixed |
People
(Reporter: wandererm, Assigned: xidorn)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 Build ID: 20180815084633 Steps to reproduce: Go to example of `mask-image` on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/mask-image#Example Add SVG fragment `#layer1` to the `mask-image` property of `#masked` See https://codepen.io/kidwm/pen/OoMoGO Actual results: The background disappeared Expected results: Show a green star just like Google Chrome
Summary: css property `mask-image` does work with svg fragment → CSS property `mask-image` does work with SVG fragment
|
||
Comment 1•6 years ago
|
||
Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5f721a664bf64fed99184a866b60c24a6afcb3a0&tochange=62cebea1d1578461a423a9ca7848706455db9ea5 Regressed by: Bug 1330412
Blocks: stylo-nightly
Status: UNCONFIRMED → NEW
status-firefox61:
--- → wontfix
status-firefox62:
--- → ?
status-firefox63:
--- → affected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → ?
Component: Untriaged → CSS Parsing and Computation
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Version: 61 Branch → 57 Branch
|
||
Updated•6 years ago
|
Flags: needinfo?(emilio)
|
|
||
Comment 2•6 years ago
|
||
This looks very related to the work that happened in bug 1301245.
See Also: → 1301245
|
|
||
Comment 3•6 years ago
|
||
Cam, do you know what's supposed to happen here? Chrome seems to always disregard the fragment, that is, in that example, it doesn't matter whether it's `foo.svg#layer1` or `foo.svg#somethingthatdoesntexist`.
Flags: needinfo?(emilio) → needinfo?(cam)
Hi, Emilio, Chrome does regard the fragment, see my updated version of https://codepen.io/kidwm/pen/OoMoGO
|
Assignee | |
Comment 5•6 years ago
|
||
This reminds me that, fragment there is actually an ambiguous case, because it can either mean it is as <mask> with id specified, or an image with the specific target element specified. Related discussion in CSS working group can be found in w3c/csswg-drafts#383. The resolution was that, when there is a fragment, browsers should try loading it as a <mask> first, and if there is no such valid <mask> element with given id, reload the file as an image. Maybe we don't load it as an image?
|
|
Assignee | |
Comment 6•6 years ago
|
||
But it is weird that, this does sound like something should happen in later place of the pipeline, but this is indeed a stylo regression (running a Firefox 57 and switching the stylo pref can see the different behavior). So the question would be what data does it trigger downstream difference...
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 7•6 years ago
|
||
This is a more extensive testcase which checks the three possible ways of using SVG: 1. using the SVG itself as image 2. using the SVG with fragment as image 3. using a <mask> element in the SVG file It seems that Chome doesn't support 3, while post-stylo Firefox doesn't support 2. Pre-stylo Firefox supports all three types, so there is still some unknown difference from the style system.
|
|
Assignee | |
Comment 8•6 years ago
|
||
I think I know where the problem is now...
Assignee: nobody → xidorn+moz
Flags: needinfo?(cam)
It seems like it could be related to mMightHaveRef in the URL structure.
|
|
Assignee | |
Comment 10•6 years ago
|
||
I think I found the right fix, and my local build works with my test case now.
|
|
Assignee | |
Comment 11•6 years ago
|
||
The corresponding handling code in the old style system can be found in: https://dxr.mozilla.org/mozilla-esr60/rev/dd52b41d2b775e5c7261ce52795268b7670635fc/layout/style/nsCSSDataBlock.cpp#65-106 mask-iage-url-hash.html is the test that don't pass without this change.
|
||
Comment 12•6 years ago
|
||
Comment on attachment 9005927 [details] Bug 1486252 - Resolve mask-image url value as an image even if it contains reference. Cameron McCormack (:heycam) has approved the revision.
Attachment #9005927 -
Flags: review+
|
||
Comment 13•6 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/991f66df3251 Resolve mask-image url value as an image even if it contains reference. r=heycam
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12795 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 16•6 years ago
|
||
Backed out changeset 991f66df3251 (bug 1486252) for eslint failure. CLOSED TREE Log: https://treeherder.mozilla.org/logviewer.html#?job_id=197138918&repo=autoland&lineNumber=1118 0:20.21 /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json 0 error xhr/xmlhttprequest-timeout-abortedonmain.html changed test types or metadata (wpt-manifest) [task 2018-09-03T02:01:49.907Z] 0:20.22 /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json 0 error fetch/cross-origin-resource-policy/fetch.any.js changed test types or metadata (wpt-manifest) [task 2018-09-03T02:01:50.001Z] 0:20.31 ERROR Manifest /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json is outdated, use |mach wpt-manifest-update| to fix. [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | payment-request/payment-response/onpayerdetailchange-attribute.https.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-179.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-50.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-169.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-155c.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-53.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-94.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-115.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.114Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | wasm/jsapi/memory/grow.any.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-17.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | input-events/idlharness.window.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-66b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | service-workers/service-worker/ServiceWorkerGlobalScope/isSecureContext.serviceworker.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-92.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/CSS2/floats/float-nowrap-1.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/reference/bq-u-u-u-green.xht in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-133.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-113.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-23.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-139b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-104.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-51.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-180a.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | worklets/audio-worklet-referrer.https.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/css-pseudo/first-letter-and-whitespace.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-161.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-174a.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-83-ref.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | webxr/xrSession_requestAnimationFrame_getDevicePose.https.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-align.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-14e.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-141b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | 2dcontext/drawing-text-to-the-canvas/2d.text.measure.actualBoundingBox.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-7b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | webxr/xrSession_requestAnimationFrame_callback_calls.https.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-transform-translatez-ref.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-vertical-ref.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-28.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-139.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-155a.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-101b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/css-values/calc-in-counter-001-ref.xhtml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | 2dcontext/drawing-text-to-the-canvas/2d.text.measure.advances.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | webxr/webGLCanvasContext_setdevice_contextlost.https.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-59.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-41a.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-15b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-175a.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-95.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-d1.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-2.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.115Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/CSS2/linebox/anonymous-inline-inherit-001.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-29b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-93.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-27.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-134b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | infrastructure/reftest/reftest_and_mismatch.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-border-gap-ref.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/reference/three-p-lime-background-except-middle.xht in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-57b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-143b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-89.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-156.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-166a.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-184c.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-111b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-167.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-123b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-166.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-96b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-97.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-102b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-display.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-70.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-130.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-155b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | webdriver/tests/take_screenshot/screenshot.py in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-137.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-origin.sub.window.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-127.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | wasm/jsapi/table/get-set.any.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/CSS2/floats/float-nowrap-8.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-grid.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | fetch/api/basic/header-value-null-byte.any.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-170c.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-156b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-14c.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-d2.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/reference/lime-bg-paras-u-g-g-u-u-g.xht in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-19b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-8.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | webdriver/tests/take_screenshot/user_prompts.py in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-137b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-155d.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.116Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-170b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | quirks/text-decoration-doesnt-propagate-into-tables/standards-ref.html in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | scroll-animations/idlharness.window.js in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-79.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-88.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-28b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-107.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-117b.xml in source but not in manifest. (wpt-manifest) [task 2018-09-03T02:05:08.117Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/meta/MANIFEST.json:0 | css/selectors/old-tests/css3-modsel-113b.xml in source but not in manifest. (wp Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=991f66df325128a737357f1a3d81a0544cc5969d Backout: https://hg.mozilla.org/integration/autoland/rev/c10ce927fed8f00e67fc131b41ffedf40b168957
Flags: needinfo?(xidorn+moz)
Upstream PR was closed without merging
|
|
||
Comment 18•6 years ago
|
||
Looks like this bug has also made WPT tests mass fail. Here is a log of what that looks like: https://treeherder.mozilla.org/logviewer.html#?job_id=197144129&repo=autoland INFO - PID 2824 | JavaScript error: Z:\task_1535942416\build\tests\web-platform\tests\tools\wptrunner\wptrunner\executors\executormarionette.py, line 82: SecurityError: Permission denied to access property "timeout" on cross-origin object 02:57:55 INFO - TEST-UNEXPECTED-TIMEOUT | /html/rendering/non-replaced-elements/the-fieldset-element-0/fieldset-default-style.html | expected OK 02:57:55 INFO - TEST-INFO took 35308ms 02:57:55 INFO - PID 2824 | 1535943475586 Marionette INFO Stopped listening on port 2828 02:57:55 INFO - PID 2824 | JavaScript error: resource://activity-stream/lib/TopSitesFeed.jsm, line 86: TypeError: setting getter-only property "_currentSearchHostname" 02:57:55 INFO - PID 2824 | [Child 4152, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 02:57:55 INFO - PID 2824 | [Parent 2824, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 02:57:55 INFO - PID 2824 | [Parent 2824, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 02:57:55 INFO - PID 2824 | [Child 4152, Main Thread] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file z:/build/build/src/xpcom/threads/nsThread.cpp, line 866 02:57:55 INFO - PID 2824 | [Parent 2824, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
|
|
Assignee | |
Comment 19•6 years ago
|
||
That is because the patch was from a relative old base, and phabricator cannot handle large files like MANIFEST.json properly. I treat it as binary file this time, which makes it override the changes in-between, and that consequently caused this mess. See bug 1446555.
Flags: needinfo?(xidorn+moz)
|
|
||
Comment 20•6 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0621cac7491 Resolve mask-image url value as an image even if it contains reference. r=heycam
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging
|
|
||
Comment 23•6 years ago
|
||
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0cd50dd88b53 Backed out changeset a0621cac7491 for wpt failures on /css/css-masking/mask-image/mask-image-url-remote-mask.html
|
|
Assignee | |
Comment 24•6 years ago
|
||
High frequent intermittent failure on mask-image-url-remote-mask.html... Maybe we don't have onload blocker for remote SVG file loading?
|
|
Assignee | |
Comment 25•6 years ago
|
||
The intermittent doesn't reproduce on my Windows machines, nor does it happen in my Ubuntu VM, even with all parallelism disabled...
|
|
Assignee | |
Comment 26•6 years ago
|
||
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #25) > The intermittent doesn't reproduce on my Windows machines, nor does it > happen in my Ubuntu VM, even with all parallelism disabled... * "Windows machine"... I only tested it on one machine.
|
|
||
Comment 27•6 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8c93f1fc5b2 Resolve mask-image url value as an image even if it contains reference. r=heycam
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
|
Assignee | |
Comment 29•6 years ago
|
||
Filed bug 1488300 for testing side work to avoid adding such hack. But I guess this doesn't need to be blocked by that.
|
||
Comment 30•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c8c93f1fc5b2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Upstream PR merged
|
||
Updated•6 years ago
|
Flags: in-testsuite+
|
|
||
Comment 32•6 years ago
|
||
Is there a high enough user impact of this bug that we should consider it for ESR60?
Flags: needinfo?(xidorn+moz)
|
|
Assignee | |
Comment 33•6 years ago
|
||
It was regressed by stylo in Firefox 57, and as far as I'm aware, this is the first report, so I don't think there is a high impact. Also users really annoyed by this bug are still able to switch off stylo in 60esr.
Flags: needinfo?(xidorn+moz)
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•