1486429 - Crash in mozilla::dom::AbortSignalImpl::Abort

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-08aa2b3d-f515-41a4-9991-245c60180827.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll exp2 
1 xul.dll mozilla::dom::AbortSignalImpl::Abort dom/abort/AbortSignal.cpp:39
2 xul.dll mozilla::dom::AbortSignal::Abort dom/abort/AbortSignal.cpp:95
3 xul.dll static bool mozilla::dom::AbortController_Binding::abort dom/bindings/AbortControllerBinding.cpp:59
4 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3296
5 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:537
6 xul.dll static bool InternalCall js/src/vm/Interpreter.cpp:588
7 xul.dll static bool Interpret js/src/vm/Interpreter.cpp:3242
8 xul.dll js::RunScript js/src/vm/Interpreter.cpp:429
9 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:561

=============================================================

There are 5 crashes (from 1 installation) in nightly 63 with buildid 20180826220129. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1478101.

[1] https://hg.mozilla.org/mozilla-central/rev?node=2d0ebe0ace0b

Comment 1

[Andrea Marchesini [:baku]]

Attachment: follower.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7318404ba4f8
AbortSignal must use nsTObserverArray for AbortFollower objects, r=smaug

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7318404ba4f8

Comment 4

[Brian Birtles (:birtles)]

I'm still hitting this a lot (several times a day) on Nightly (64).

Comment 5

[Fernando Hartmann]

I'm using 63b3 and crashing with https://crash-stats.mozilla.com/report/index/bp-2326eb21-63fd-4ba0-9b68-4e8a70180906 while using Waze map editor.
Should this be solved in 63b3 ? Or my crash is about other bug ?

Comment 6

[Andrea Marchesini [:baku]]

We have a separate bug for this crash: Bug 1488427

Comment 7

[Andrea Marchesini [:baku]]

Fernando, do you have a STR or the crash is random?

Comment 8

[Fernando Hartmann]

It's a STR, very easy to reproduce.
* go to https://www.waze.com/editor/#
* Login
* right click on the map and start to drag the map around, in some seconds the crash happens. 

Do you want I post this on Bug 1488427 ?

Comment 9

[Andrea Marchesini [:baku]]

Thanks a lot for this STR. I wrote a patch.