1486453 - Screenshot uploaded to a mozilla server instead of saved to a file

Status: RESOLVED INCOMPLETE

(Firefox :: Screenshots, enhancement)

Description

[Ricardo Fernández Pascual]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180815084633

Steps to reproduce:

I took a screenshot using the context menu. Then, I clicked on the “Save” button expecting that it would be saved to a file. 


Actual results:

Instead, the image got uploaded to a server at mozilla.org.


Expected results:

A file dialog should open asking me for a location and a name to save the image to a file.

The current behaviour breaks every reasonable user expectations, as “Save” means “Save to a file” in every other program in existence and has meant so since ever. Plus, it sends potentially private information to a server not under the user control without warning. This behaviour is surprising and very rude.

Comment 1

[Daniel Bodea [:danibodea]]

Hello Ricardo Fernández Pascual,

I am attempting to confirm your issue, but I cannot, based on the information received in the description.
Please provide us with a detailed step-by-step tutorial to reproduce the unexpected issue. If it would be easier for you, a screen recording would definitely help. (You can use Icecream screen recorder: https://icecreamapps.com/Screen-Recorder/)

Does this issue reproduce constantly?
Does it also happen in the case of the Nightly browser version or only the Release browser version?
Please test if the issue is reproducible in safe mode, here is a link that can help you: https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Thank you for your contribution!

Comment 2

[Ricardo Fernández Pascual]

(In reply to Bodea Daniel [:danibodea] from comment #1)
> I am attempting to confirm your issue, but I cannot, based on the
> information received in the description.
> Please provide us with a detailed step-by-step tutorial to reproduce the
> unexpected issue. 

Step by step tutorial:

 1 - Right-click almost anywhere in any web page.
 2 - Select “Take a Screenshot” in the context menu that appears.
 3 - Follow the instructions to take any web page screenshot. For example, select the “Save full page” button that appears near the upper right corner of the window. 
 4 - A preview of the screenshot appears, alongside four buttons (see attached image): X, Copy, Download and Save.
 5 - Click “Save”. 
 6 - Instead of saving the sreenshot, Firefox uploads it without any warning to a server, thereby leaking potentially user private information to Mozilla.

The root of the problem is that the buttons are misnamed. “Download” should be called “Save” because that is what it seems to be doing after further testing (and nothing is being downloaded, the pixels were already in my computer to begin with!), while “Save” should be called “Upload to [some mozilla cloud service]”.

The current naming of the buttons is misleading and breaks user expectations in a potentially dangerous way, because “Save” means “write something to a file” in almost every other program, including in other parts of Firefox. Instead, this button sends the screenshot, which may contain private information, to a server out of the user control unexpectedly and without warning (I was certainly surprised when it happened).

> Does this issue reproduce constantly?

Yes, it is a misdesign in the UI, so it happens always.

> Does it also happen in the case of the Nightly browser version or only the
> Release browser version?

The behaviour in current nightly is the same.

> Please test if the issue is reproducible in safe mode, here is a link that
> can help you:
> https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-
> mode

This is certainly not relevant to the issue. Also, I tested the nightly version without any add-on.

Best regards,

Comment 3

[Ricardo Fernández Pascual]

Attachment: Screenshot of the misnamed buttons

Comment 4

[Daniel Bodea [:danibodea]]

I can confirm the reproduction of the possible issue. This bug can be treated as an enhancement since it regards changing the original design of the "Take a screenshot" feature.

The component of choice is (Firefox) Screenshots. If it is not the right one, please change it to a more specific one.

Thank you!

Comment 5

[Wil Clouser [:clouserw]]

Hi.  Thanks for filing this.  It's already being tracked at https://github.com/mozilla-services/screenshots/issues/3603 and https://github.com/mozilla-services/screenshots/issues/3503 (seems like one of those should be closed as a duplicate, but for now, they are both open)