[webdriver] Get rid of camel-case for pageLoad and sessionId

RESOLVED FIXED in Firefox 63

Status

enhancement
P2
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Version 3
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Instead use `page_load` and `session_id`. `pageLoad` and `sessionId` should only be used for serialization and deserialization with Serde.
Comment on attachment 9004220 [details] [diff] [review]
[webdriver] Rename sessionId to session_id for NewSessionResponse

Review of attachment 9004220 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/webdriver/src/response.rs
@@ +77,4 @@
>      pub fn new(session_id: String, capabilities: Value) -> NewSessionResponse {
>          NewSessionResponse {
>              capabilities: capabilities,
> +            session_id: session_id,

With the renaming of sessionId, this can now be written like this
too:

> NewSessionResponse { capabilities, session_id }

Not a required change, but just saying for future reference.
Attachment #9004220 - Flags: review?(ato) → review+
Attachment #9004222 - Flags: review?(ato) → review+
(In reply to Andreas Tolfsen ﹝:ato﹞ from comment #4)
> ::: testing/webdriver/src/response.rs
> @@ +77,4 @@
> >      pub fn new(session_id: String, capabilities: Value) -> NewSessionResponse {
> >          NewSessionResponse {
> >              capabilities: capabilities,
> > +            session_id: session_id,
> 
> With the renaming of sessionId, this can now be written like this
> too:
> 
> > NewSessionResponse { capabilities, session_id }
> 
> Not a required change, but just saying for future reference.

Oh, I haven't known that. I will make this change.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4cb950d23e5
[webdriver] Rename pageLoad to page_load for TimeoutsResponse. r=ato
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d702b7e5d80
[webdriver] Rename sessionId to session_id for NewSessionResponse. r=ato
https://hg.mozilla.org/mozilla-central/rev/b4cb950d23e5
https://hg.mozilla.org/mozilla-central/rev/9d702b7e5d80
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.