1486467 - [webdriver] Get rid of camel-case for pageLoad and sessionId

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Instead use `page_load` and `session_id`. `pageLoad` and `sessionId` should only be used for serialization and deserialization with Serde.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: [webdriver] Rename sessionId to session_id for NewSessionResponse

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: [webdriver] Rename pageLoad to page_load for TimeoutsResponse

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4bcdb6ba1094fe8f663026978e2232b3ae70c04

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 9004220 [details] [diff] [review]
[webdriver] Rename sessionId to session_id for NewSessionResponse

Review of attachment 9004220 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/webdriver/src/response.rs
@@ +77,4 @@
>      pub fn new(session_id: String, capabilities: Value) -> NewSessionResponse {
>          NewSessionResponse {
>              capabilities: capabilities,
> +            session_id: session_id,

With the renaming of sessionId, this can now be written like this
too:

> NewSessionResponse { capabilities, session_id }

Not a required change, but just saying for future reference.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Andreas Tolfsen ﹝:ato﹞ from comment #4)
> ::: testing/webdriver/src/response.rs
> @@ +77,4 @@
> >      pub fn new(session_id: String, capabilities: Value) -> NewSessionResponse {
> >          NewSessionResponse {
> >              capabilities: capabilities,
> > +            session_id: session_id,
> 
> With the renaming of sessionId, this can now be written like this
> too:
> 
> > NewSessionResponse { capabilities, session_id }
> 
> Not a required change, but just saying for future reference.

Oh, I haven't known that. I will make this change.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4cb950d23e5
[webdriver] Rename pageLoad to page_load for TimeoutsResponse. r=ato
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d702b7e5d80
[webdriver] Rename sessionId to session_id for NewSessionResponse. r=ato

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b4cb950d23e5
https://hg.mozilla.org/mozilla-central/rev/9d702b7e5d80