Closed Bug 1486476 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 12692 - Grid properties should not accept unitless length quirk

Categories

(Core :: Layout, enhancement, P4)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12692 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12692
Details from upstream follow.

Hwanseung Lee <hs1217.lee@samsung.com> wrote:
>  Grid properties should not accept unitless length quirk
>  
>  The following properties are currently accepting unit lengths
>  in quirks mode, contrary to spec[1].
>  - grid-auto-columns
>  - grid-auto-rows
>  - grid-template-columns
>  - grid-template-rows
>  so it should disallow.
>  
>  [1]https://quirks.spec.whatwg.org/#the-unitless-length-quirk
>  
>  Bug: 876704
>  Change-Id: I3af3d01f96efb3b3f788ca02893b12c7ae683c20
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1190045
>  WPT-Export-Revision: 713fb989e4ff50c43a7753bde390aed6437c17a8
Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 34 subtests
OK     : 1
PASS   : 34
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b515e74c573c
[wpt PR 12692] - Grid properties should not accept unitless length quirk, a=testonly
https://hg.mozilla.org/mozilla-central/rev/b515e74c573c
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.