1486480 - We don't have memory reporting for custom element data

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we don't memory-report any members of nsExtendedDOMSlots (see FragmentOrElement::nsDOMSlots::SizeOfIncludingThis).  That means we don't memory-report custom element data.

In DMD, I am seeing multiple megabytes of this allocated in the chrome process, because we allocate it for every single XUL element.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

One thing which complicates memory reporting here is that nsExtendedDOMSlots can be allocated separately or as part of nsDOMSlots (in which case the whole thing is FatSlots).
XUL elements should use usually (always?) FatSlots.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I'm working on this right now, fwiw.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1486480. Add memory reporting for custom element data. r=smaug

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9004277 [details]
Bug 1486480.  Add memory reporting for custom element data.  r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dc25841ff4f
Add memory reporting for custom element data.  r=smaug

Comment 6

[Eliza Balazs [:ebalazs_]]

Backed out changeset 9dc25841ff4f (Bug 1486480) for causing Assertion failure: extendedSlots, at /builds/worker/workspace/build/src/dom/base/FragmentOrElement.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9dc25841ff4f96a31bb150fee517a589c02aa7c6&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&selectedJob=196169048

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196169048&repo=autoland&lineNumber=2969

Backout push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=edb57a49546ffb8911e718059e991342d3fd74be&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry

Comment 7

[Boris Zbarsky [:bzbarsky]]

Bah.  OwnsExtendedSlots() returns true if there are no extended slots at all.  And this is the only consumer, and moz_malloc_size_of is null-safe.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4292aeb328da
Add memory reporting for custom element data.  r=smaug

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4292aeb328da