Closed Bug 1486481 Opened 6 years ago Closed 6 years ago

Localization fallback strategy for CFR messages

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Iteration:
63.5 - Sep 3
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug)

Details

The way CFR messages/payload are set up right now https://phabricator.services.mozilla.com/D4266#92194 doesn't allow for an easy fallback strategy.
Normally you specify an `id` to fluent and the library will take care of adding extra attributes on that element (label, accesskey etc) example: https://searchfox.org/mozilla-central/rev/e126996d9b0a3d7653de205898517f4f5b632e7f/browser/locales/en-US/browser/preferences/permissions.ftl#23
Want we want is: if `string_id` is specfied in the payload use that and count on fluent to do the work. Otherwise the payload will specify all the attributes (currently label and accesskey) and we will add them to the elements.
Blocks: 1471328
Severity: normal → enhancement
Priority: -- → P2
Iteration: --- → 63.5 - Sep 3
Priority: P2 → P1
This was implemented as part of bug 1485418
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
status-firefox63: --- → fixed
Target Milestone: --- → Firefox 63
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.