1486486 - Jumping between processes in about:memory still changes the URL bar

Status: RESOLVED FIXED

(Toolkit :: about:memory, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

The bits added in bug 929826 to override normal link behavior look like this:

    link.addEventListener("click", function(event) {
      document.documentElement.scrollTop =
        document.querySelector(event.target.href).offsetTop;
      event.preventDefault();
    });

This doesn't work, because event.target.href is an absolute URI if event.target is an <a>.  So this is passing strings like "about:memory#end0" to querySelector, which throws because that's not a valid selector.  As a result, the default action happens.

That said, fixing this to use getAttribute("href") causes scrolling to happen to not-quite-the-right-place, because the offsetTop of the element doesn't actually correspond to its viewport position, since the offsetParent's rect is not at the top-left of the viewport.  So maybe this whole chunk should just be removed.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove bogus link override code in about:memory

It's throwing because things like `about:memory#end0` aren't valid selectors.

Comment 2

[Nicholas Nethercote [inactive]]

Thanks for identifying this. I agree that the behaviour obtained with this code gone is reasonable... given that it's the same behaviour as we currently get, minus the thrown exception :)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9005535 [details] [diff] [review]
Remove bogus link override code in about:memory

r=me

Comment 4

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f235504faa6982909a0d8046218af57c49ddb519

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d929a08b7cce
Remove bogus link override code in about:memory. r=bz

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d929a08b7cce