Add widevine headers to ThirdPartyPaths and .clang-format-ignore

RESOLVED FIXED in Firefox -esr60


10 months ago
6 months ago


(Reporter: bryce, Assigned: bryce)


Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox63 fixed)



(2 attachments)



10 months ago
We have copies of the content decryption module headers used for the Widevine CDM in dom/media/gmp/widevine-adapter. We do not format these headers in order ease comparisons with upstream. As such, we should exclude them from clang-formatting.

Comment 1

10 months ago
We wish to keep the widevine headers in the same formatting as upstream to
ease comparison and as we do not modify these files. This patch adds the
existing headers, as well as another we anticipate pulling down for our next
bump (content_decryption_module_proxy.h) to the ignored paths. These files are
ignored individually rather than the whole directory they're in, as we also
have Mozilla code in that dir.
Comment on attachment 9004260 [details]
Bug 1486502 - Add widevine CDM headers to third party paths, clang-format ignore.

Sylvestre Ledru [:sylvestre] has approved the revision.
Attachment #9004260 - Flags: review+

Comment 3

10 months ago
Pushed by
Add widevine CDM headers to third party paths, clang-format ignore. r=sylvestre

Comment 4

10 months ago
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

Comment 5

6 months ago
Posted patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #9031022 - Flags: approval-mozilla-esr60?
Comment on attachment 9031022 [details] [diff] [review]
ESR patch

OK for uplift to ESR for clang-format project.
Attachment #9031022 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.