Closed Bug 1486547 Opened 6 years ago Closed 6 years ago

In a protcol's class heirarchy there are two instances of a field named mState, this is confusing

Categories

(Core :: IPC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

Details

Attachments

(1 file)

I'm going to rename one of them to make reading the code easier.
There's also a field named mState on IProtocol, and this reduces confusion.
Comment on attachment 9004298 [details]
Bug 1486547 - renamed the mState field on generated protocol classes; r?froydnj

Nathan Froyd [:froydnj] has approved the revision.
Attachment #9004298 - Flags: review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a38246f1a70
renamed the mState field on generated protocol classes; r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a38246f1a70
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: