Closed
Bug 1486562
Opened 6 years ago
Closed 6 years ago
Record reference count changes for SourceListener
Categories
(Core Graveyard :: Web Replay, defect)
Core Graveyard
Web Replay
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
2.77 KB,
patch
|
jib
:
review+
|
Details | Diff | Splinter Review |
SourceListener is used on multiple threads, and when using web replay the thread which it is destroyed on can vary between recording and replaying, causing the replay to diverge from the recording. The attached patch includes reference count changes to SourceListener in web replay recordings, so that it is destroyed at a consistent point in the execution.
Attachment #9004308 -
Flags: review?(jib)
|
||
Comment 1•6 years ago
|
||
Comment on attachment 9004308 [details] [diff] [review] patch Review of attachment 9004308 [details] [diff] [review]: ----------------------------------------------------------------- Happy to r+ since this appears to only impact recording/replay. My mind wanders with questions about the impacts of record/replay on real-time media playback, but will just cc a few people for now.
Attachment #9004308 -
Flags: review?(jib) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/641bced4e986 Record reference count changes for SourceListener, r=jib.
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/641bced4e986
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•