Record reference count changes for SourceListener

RESOLVED FIXED in Firefox 63

Status

()

defect
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks 1 bug)

Trunk
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
SourceListener is used on multiple threads, and when using web replay the thread which it is destroyed on can vary between recording and replaying, causing the replay to diverge from the recording.  The attached patch includes reference count changes to SourceListener in web replay recordings, so that it is destroyed at a consistent point in the execution.
Attachment #9004308 - Flags: review?(jib)
Comment on attachment 9004308 [details] [diff] [review]
patch

Review of attachment 9004308 [details] [diff] [review]:
-----------------------------------------------------------------

Happy to r+ since this appears to only impact recording/replay. My mind wanders with questions about the impacts of record/replay on real-time media playback, but will just cc a few people for now.
Attachment #9004308 - Flags: review?(jib) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/641bced4e986
Record reference count changes for SourceListener, r=jib.
https://hg.mozilla.org/mozilla-central/rev/641bced4e986
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.