Closed Bug 1486565 Opened 6 years ago Closed 6 years ago

Don't initialize cubeb when recording/replaying

Categories

(Core Graveyard :: Web Replay, enhancement)

Product:
Core Graveyard
Component:
Web Replay
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

patch
963 bytes, patch
kinetik
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
cubeb initialization calls some library APIs that aren't redirected yet for Web Replay, and since we don't support audio or other media when recording/replaying it seems best for now to avoid initializing cubeb when recording/replaying.
Attachment #9004309 - Flags: review?(kinetik)
Attachment #9004309 - Flags: review?(kinetik) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abd2efff1efd
Don't initialize cubeb when recording/replaying, r=kinetik.
https://hg.mozilla.org/mozilla-central/rev/abd2efff1efd
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: