Closed Bug 1486572 Opened 2 years ago Closed 2 years ago

[wdspec] Create tests for "Is Element Enabled" command

Categories

(Testing :: geckodriver, enhancement, P1)

Version 3
enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(2 files, 1 obsolete file)

There haven't been written any tests for this command yet. Lets get at least the basic ones added.
The command isn't that complex so I think that I can add all the necessary tests.
Summary: [wdspec] Create basic tests for "Is Element Enabled" command → [wdspec] Create tests for "Is Element Enabled" command
Comment on attachment 9004475 [details] [diff] [review]
[marionette] Always return false for "Is Element Enabled" command and XML documents

Review of attachment 9004475 [details] [diff] [review]:
-----------------------------------------------------------------

The WebDriver specification prose is a bit clunkly here, but I think
this is what it says.
Attachment #9004475 - Flags: review?(ato) → review+
Comment on attachment 9004476 [details] [diff] [review]
[wdspec] Create tests for "Is Element Enabled" command

Review of attachment 9004476 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/webdriver/tests/is_element_enabled/enabled.py
@@ +82,5 @@
> +    assert_success(result, True)
> +
> +
> +def test_xml_always_not_enabled(session):
> +    session.url = inline("""<note></note>""", doctype="xml")

You also want a test for XHTML here, given it has characteristics
that are different to XML.  Testing an <input disabled="disabled">
in XHTML would probably be a good idea.
Attachment #9004476 - Flags: review?(ato) → review+
Attachment #9004476 - Attachment is obsolete: true
Attachment #9004841 - Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaab9dff4a22
[marionette] Always return false for "Is Element Enabled" command and XML documents.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb891993d3e
[wdspec] Create tests for "Is Element Enabled" command.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12737 for changes under testing/web-platform/tests
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/aaab9dff4a22
https://hg.mozilla.org/mozilla-central/rev/3eb891993d3e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.