Closed Bug 1486573 Opened Last year Closed Last year

Track changes to nsPipeOutputStream writer count

Categories

(Core :: Web Replay, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We already track reference count changes to nsPipe when recording/replaying, which contains nsPipeOutputStream and controls when it is destroyed.  The nsPipeOutputStream contains a separate reference count, however, whose releases can trigger a close on the stream before the pipe itself has been destroyed.  Changes to this reference count should also be tracked in recordings, so that the close happens at a consistent point between recording and replaying.
Attachment #9004316 - Flags: review?(nfroyd)
Attachment #9004316 - Flags: review?(nfroyd) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e5a6a15439f
Track changes to nsPipeOutputStream writer count, r=froydnj.
https://hg.mozilla.org/mozilla-central/rev/9e5a6a15439f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.