Closed
Bug 1486611
Opened 6 years ago
Closed 6 years ago
Searchbox Autocomplete popup shouldn't be transparent
Categories
(DevTools :: Shared Components, defect, P1)
DevTools
Shared Components
Tracking
(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 unaffected, firefox63 verified)
VERIFIED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | unaffected |
| firefox61 | --- | unaffected |
| firefox62 | --- | unaffected |
| firefox63 | --- | verified |
People
(Reporter: ntim, Assigned: nchevobbe)
References
Details
(Keywords: regression)
Attachments
(3 files)
Screen Shot 2018-08-25 at 10.12.36 PM.png
Nicolas, do you think your recent changes could have caused this?
Flags: needinfo?(nchevobbe)
|
Assignee | |
Comment 1•6 years ago
|
||
Thanks for reporting Tim. Yes it is caused by Bug 1478435. I'll provide a patch for review shortly.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Component: Netmonitor → Shared Components
Depends on: 1478435
Flags: needinfo?(nchevobbe)
Priority: -- → P1
Summary: Autocomplete popup shouldn't be transparent in netmonitor → Searchbox Autocomplete popup shouldn't be transparent
|
|
Assignee | |
Comment 2•6 years ago
|
||
In Bug 1478435 a selector was removed causing the background of the SearchBox autocomplete to be transparent and without box-shadow. This patch add the needed rule in the CSS. We take this as an opportunity to fix a small positioning issue by making sure the element stick to the left.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Here's how it looks now
|
Reporter | |
Comment 4•6 years ago
|
||
Comment on attachment 9004478 [details] Bug 1486611 - Fix SearchBox styling; r=ntim. Tim Nguyen :ntim has approved the revision.
Attachment #9004478 -
Flags: review+
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca333637e6d0 Fix SearchBox styling; r=ntim.
|
|
Reporter | |
Comment 6•6 years ago
|
||
Copied from Phabricator: Can you file a follow up bug about using var(--theme-arrowpanel-background) for all tooltips ? It's already being used for .tooltip-container[type="doorhanger"] > .tooltip-panel (the meatball menu), and i don't see any good reason not to expand this to all arrow tooltips.
Flags: needinfo?(nchevobbe)
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ca333637e6d0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
||
Updated•6 years ago
|
Keywords: regression
|
||
Updated•6 years ago
|
Blocks: 1478435
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
No longer depends on: 1478435
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
|
Reporter | |
Comment 8•6 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #6) > Copied from Phabricator: > > Can you file a follow up bug about using var(--theme-arrowpanel-background) > for all tooltips ? It's already being used for > .tooltip-container[type="doorhanger"] > .tooltip-panel (the meatball menu), > and i don't see any good reason not to expand this to all arrow tooltips. Filed bug 1491547
|
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(nchevobbe)
|
||
Comment 9•6 years ago
|
||
Reproduced the issue on 63.0a1 (2018-08-27). Verified with 63.0b7, 64.0a1 on Win10x64, Ubuntu 16.04LTS, macOS 10.13 and can confirm that the background is properly displayed.
You need to log in
before you can comment on or make changes to this bug.
Description
•