Closed Bug 1486631 Opened 2 years ago Closed 2 years ago

[Export] Add CFR, search shortcut fixes, and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 63
Iteration:
63.5 - Sep 3
Tracking Status
firefox63 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/4ad851b3bc9ab6eac25b09d238e5276ef9b674e9...236d725f595ccefb394cfb8d0e6256b5d857fe12

Attachments

(1 file)

No description provided.
Summary: Add ... and bug fixes → Add CFR, search shortcut fixes, and bug fixes to Activity Stream
Comment on attachment 9004384 [details]
Bug 1486631 - Add CFR, search shortcut fixes, and bug fixes to Activity Stream

Ursula Sarracini (:ursula) has approved the revision.
Attachment #9004384 - Flags: review+
Comment on attachment 9004384 [details]
Bug 1486631 - Add CFR, search shortcut fixes, and bug fixes to Activity Stream

Ed Lee :Mardak has approved the revision.
Attachment #9004384 - Flags: review+
Pushed by khudson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a89328c87888
Add CFR, search shortcut fixes, and bug fixes to Activity Stream r=Mardak,ursula
Bisecting points to bug 1471389 https://github.com/mozilla/activity-stream/commit/1407877b8661fbae8e6d42c367415db99900f33e

There's a bunch of Console message: [JavaScript Error: "[Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://browser/content/browser.js :: onLocationChange :: line 4822"  data: no]"]
onLocationChange@chrome://browser/content/browser.js:4822:7

But that seems unrelated. (Appears before that commit.)

I haven't looked at the code, but I'm guessing onboarding is waiting for some event that might get delayed or something in the page is preventing the "load" ??
Flags: needinfo?(usarracini)
Actually, reverting the ActivityStream.jsm json pref change for asrouter.messageProviders fixes the issue:

https://github.com/mozilla/activity-stream/commit/1407877b8661fbae8e6d42c367415db99900f33e#diff-72cd6f5b7a8d1ffe4176acd491757fd0
Before the change, onboarding enabled = false always vs it becomes true, and that hides the non-router onboarding.
Yup, I'll fix this and then we'll re-export. Sorry about that
Flags: needinfo?(usarracini)
Flags: needinfo?(khudson)
User Story: (updated)
Pushed by khudson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/332b73bd0c42
Add CFR, search shortcut fixes, and bug fixes to Activity Stream r=Mardak,ursula
Blocks: 1471328
Summary: Add CFR, search shortcut fixes, and bug fixes to Activity Stream → Add CFR, search shortcut fixes, and bug fixes to Activity Stream [export]
https://hg.mozilla.org/mozilla-central/rev/332b73bd0c42
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Depends on: 1484289, 1484034
Depends on: 1486931
Blocks: 1487538
Whiteboard: [export]
Component: Activity Streams: Newtab → Messaging System
No longer blocks: 1471328
Type: enhancement → task
Component: Messaging System → New Tab Page
Summary: Add CFR, search shortcut fixes, and bug fixes to Activity Stream [export] → [Export] Add CFR, search shortcut fixes, and bug fixes to Activity Stream
You need to log in before you can comment on or make changes to this bug.