1486688 - [wpt-sync] Sync PR 12714 - [LayoutNG] Fix legacy initiated abspos invalidation

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12714 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12714
Details from upstream follow.

Aleks Totic <[e-mail]> wrote:
>  [LayoutNG] Fix legacy initiated abspos invalidation
>  
>  Bug:
>  
>  LayoutBlock::LayoutPositionedObject had a static position check whether
>  child reflow was necessary:
>    if (.... ||
>         (!IsLayoutNGBlockFlow() &&
>          NeedsLayoutDueToStaticPosition(positioned_object))))
>      layout_scope.SetChildNeedsLayout(positioned_object);
>  This check would skip reflow for all NGBlockFlow children.
>  This is incorrect. If child abspos layout was initiated by Legacy,
>  we should check static position.
>  
>  Fix:
>  There was no way to tell in current code whether child abspos layout
>  was initiated by legacy.
>  Added a flag is_legacy_initiated_out_of_flow_layout_.
>  Flag was added to LayoutBlock per ikilpatrick recommendation.
>  Flag is set to true in LayoutNGBlockFlow::UpdateOutOfFlowBlockLayout
>  Flag is set to false in NGOutOfFlowLayout.
>  
>  With this fix, checkboxes on code review page are correct.
>  
>  Bug: 863865
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: Ifc55ac03b76dd1aa2113181681bca1b5a2832fb2
>  Reviewed-on: https://chromium-review.googlesource.com/1190723
>  WPT-Export-Revision: ba6551676ab7b95020dd5551c121a56c03bf6467

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8504ff06031ac2e88794672bdbac36bcc7923f8

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0907284556416ca6fe633666266b7aa4f5a75439

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=181bfd33f7a0993557a50c37182e78fe9aa8a30f

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 1 tests
PASS   : 1

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d8d2020e67090d87ef8ddda30d181ea0e3d9098

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd2b67d1e1e5
[wpt PR 12714] - [LayoutNG] Fix legacy initiated abspos invalidation, a=testonly

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/cd2b67d1e1e5