1486703 - Developer Tools -> Storage -> Cookie Displays wrong values

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[michal.holecek]

Attachment: cookie_hostonly_bug.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704192850

Steps to reproduce:

When I've displayed cookies on Devtools -> Storage in almost every cookie "hostonly" parameter for each cookie had different values in the table, and the detailed view (see attached screenshot). 


Actual results:

Cookie parameter, boolean "hostonly" had true and false displayed at the same time.


Expected results:

The values are supposed to be same.

Comment 1

[Julian Descottes [:jdescottes]]

Indeed, thanks for logging!

Comment 2

[Julian Descottes [:jdescottes]]

Cookies are displayed in the sidebar and in the table. The StorageInspector maps some cookie values to custom column names/property names. For instance it maps isDomain to hostOnly. When displayed in the sidebar it also uses the opposite value of isDomain. However the table has no idea that it should use the opposite value, so it just displays "isDomain" in the "hostOnly" column. 

Not sure how some rows could be in sync though. In my testing so far they are always consistently wrong.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1486703 - Display correct hostOnly values in storage inspector;r=miker

Comment 4

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b956cd17a6078a327a204342dab252aea0432025

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 9005441 [details]
Bug 1486703 - Display correct hostOnly values in storage inspector;r=miker

Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d18bb6911bb3
Display correct hostOnly values in storage inspector;r=miker

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d18bb6911bb3