Closed
Bug 1486729
Opened 6 years ago
Closed 6 years ago
[Static-Analysis][Clang-Tidy] As default, a checker should be publish by default.
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
Details
Attachments
(1 file)
As it can be seen from [1] most of the checkers have the attribute 'publish' set to 'yes' hence the default behavior should be to publish the checker and by this we eliminate all of the 'publish: !!bool yes'. [1] https://dxr.mozilla.org/mozilla-central/source/tools/clang-tidy/config.yaml#15
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bpostelnicu
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try jobs to make sure we don't regress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92aa6ee36ad80b97c8e1f926d84201f8180d68f6 https://hg.mozilla.org/try/rev/49d767191fb8114b807dd95c76cda58e35dd8819
|
||
Updated•6 years ago
|
Attachment #9004522 -
Attachment description: Bug 1486729 - [Static-Analysis][Clang-Tidy] As default a checker should be publish by default. r=janx → Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=janx
|
|
Assignee | |
Comment 3•6 years ago
|
||
Also win: https://treeherder.mozilla.org/#/jobs?repo=try&revision=49d767191fb8114b807dd95c76cda58e35dd8819
|
|
Assignee | |
Updated•6 years ago
|
Summary: [Static-Analysis][Clang-Tidy] As default a checker should be publish by default. → [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default.
|
|
Assignee | |
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaed34af0009c09b2d0253266c6a93f75f46d244&selectedJob=196217811
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9004522 [details] Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre Sylvestre Ledru [:sylvestre] has approved the revision.
Attachment #9004522 -
Flags: review+
|
|
||
Updated•6 years ago
|
Attachment #9004522 -
Attachment description: Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=janx → Bug 1486729 - [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/adbee46f307f [Static-Analysis][Clang-Tidy] As default, a checker should be publish by default. r=sylvestre
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/adbee46f307f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•