1486757 - Fix broken check for waitForAnnotation in download's head.js

Status: RESOLVED FIXED

(Toolkit :: Downloads API, enhancement, P1)

Description

[Mark Banner (:standard8)]

I took a brief look at bug 1480267 for the possible reasons in the recent uplift.

I realised that in bug 1468980, I changed waitForAnnotation in the head.js file, to use the new places API.

What I forgot was that if the page hasn't been added to the database yet, then PlacesUtils.history.fetch will return null.

The result check I added in the waitForCondition, doesn't account for that, so sometimes we see things such as:

Unexpected exception Should have found annotation downloads/destinationFileURI for http://www.example.com:44227/interruptible.txt - threw exception: TypeError: pageInfo is null, can't access property "annotations" of it

I don't think this will fix all the intermittents of test_DownloadLegacy.js as there were some existing beforehand. However, it should help return to previous levels.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1486757 - Check that pageInfo is also valid in waitForAnnotation in downloads's head.js to avoid intermittents.

Comment 2

[:Paolo Amadini]

Comment on attachment 9004544 [details]
Bug 1486757 - Check that pageInfo is also valid in waitForAnnotation in downloads's head.js to avoid intermittents.

:Paolo Amadini has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcf51e940502
Check that pageInfo is also valid in waitForAnnotation in downloads's head.js to avoid intermittents. r=paolo

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/bcf51e940502